meta: Add a small benchmark suite to sentry-core #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The benchmarks so far test the scope with tags and breadcrumbs in a few situations: * inactive client, * active client, only scope manipulation * active client, scope and capturing messages The Benchmarks also allow measuring the "minimal API" mode, which basically removes the complete implementation at compile time. Measurements on my system are: Minimal API (compile-time noop): ~2.6ns Tags: * inactive: 66ns * active: 26us * capture: 53us Breadcrumbs: * inactive: 2us * active: 52us * capture: 88us
flub
approved these changes
Jan 8, 2021
|
|
||
| let client = Arc::new(sentry::Client::from(sentry::ClientOptions { | ||
| dsn: Some("https://public@sentry.invalid/1".parse().unwrap()), | ||
| // lol, this double arcing -_- |
There was a problem hiding this comment.
The first is impl TransportFactory for Arc<Transport>, the second one is because clientoptions takes an Arc<dyn TransportFactory> explicitly :-(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmarks so far test the scope with tags and breadcrumbs in a few
situations:
The Benchmarks also allow measuring the "minimal API" mode, which
basically removes the complete implementation at compile time.
Measurements on my system are:
Minimal API (compile-time noop): ~2.6ns
Tags:
Breadcrumbs: