Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate enable_tracing in favor of traces_sample_rate #2535

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

sl0thentr0py
Copy link
Member

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.90%. Comparing base (1111acb) to head (5fe5f91).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry/configuration.rb 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2535      +/-   ##
==========================================
- Coverage   67.90%   67.90%   -0.01%     
==========================================
  Files         118      118              
  Lines        4481     4483       +2     
==========================================
+ Hits         3043     3044       +1     
- Misses       1438     1439       +1     
Components Coverage Δ
sentry-ruby 60.12% <50.00%> (-0.01%) ⬇️
sentry-rails 97.48% <ø> (ø)
sentry-sidekiq ∅ <ø> (∅)
sentry-resque 92.64% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files with missing lines Coverage Δ
sentry-rails/lib/generators/sentry_generator.rb 100.00% <ø> (ø)
sentry-ruby/lib/sentry/configuration.rb 85.27% <50.00%> (-0.25%) ⬇️

@sl0thentr0py
Copy link
Member Author

fixing jruby stuff separately

@sl0thentr0py sl0thentr0py marked this pull request as draft February 3, 2025 13:30
@sl0thentr0py sl0thentr0py marked this pull request as ready for review February 4, 2025 12:27
@sl0thentr0py sl0thentr0py force-pushed the neel/deprecate-enable-tracing branch from 45d667c to 3b5cde4 Compare February 4, 2025 12:28
@sl0thentr0py sl0thentr0py requested a review from solnic February 4, 2025 14:00
@sl0thentr0py sl0thentr0py force-pushed the neel/deprecate-enable-tracing branch from 3b5cde4 to 5fe5f91 Compare February 6, 2025 12:43
@sl0thentr0py sl0thentr0py merged commit cfd5059 into master Feb 6, 2025
112 of 114 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/deprecate-enable-tracing branch February 6, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants