Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mutex sync to SessionFlusher aggregates #2469

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

sl0thentr0py
Copy link
Member

fixes #2468

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.17%. Comparing base (a9b3687) to head (1a32a15).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2469   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files         128      128           
  Lines        4825     4829    +4     
=======================================
+ Hits         4737     4741    +4     
  Misses         88       88           
Components Coverage Δ
sentry-ruby 98.57% <100.00%> (+<0.01%) ⬆️
sentry-rails 97.08% <ø> (ø)
sentry-sidekiq 96.96% <ø> (ø)
sentry-resque 92.85% <ø> (ø)
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry/session_flusher.rb 100.00% <100.00%> (ø)

@sl0thentr0py sl0thentr0py force-pushed the neel/fix-sessions-mutex branch from 94be884 to 1a32a15 Compare November 21, 2024 14:06
@sl0thentr0py sl0thentr0py requested a review from solnic November 21, 2024 14:07
@sl0thentr0py sl0thentr0py merged commit f225138 into master Nov 28, 2024
142 checks passed
@sl0thentr0py sl0thentr0py deleted the neel/fix-sessions-mutex branch November 28, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError in session_flusher.rb
2 participants