Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skipping 'connect' spans #2364

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Aug 8, 2024

Fixes #2338

@solnic solnic linked an issue Aug 8, 2024 that may be closed by this pull request
@solnic solnic changed the title Fix skipping spans Fix skipping 'connect' spans Aug 8, 2024
@getsentry getsentry deleted a comment from github-actions bot Aug 8, 2024
@solnic solnic marked this pull request as ready for review August 8, 2024 11:52
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (e4571d9) to head (f315a15).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2364      +/-   ##
==========================================
+ Coverage   98.67%   98.69%   +0.01%     
==========================================
  Files         208      208              
  Lines       13748    13754       +6     
==========================================
+ Hits        13566    13574       +8     
+ Misses        182      180       -2     
Components Coverage Δ
sentry-ruby 99.05% <ø> (+0.02%) ⬆️
sentry-rails 97.41% <ø> (ø)
sentry-sidekiq 97.01% <ø> (ø)
sentry-resque 96.79% <ø> (ø)
sentry-delayed_job 98.92% <ø> (ø)
sentry-opentelemetry 100.00% <100.00%> (ø)
Files Coverage Δ
...lemetry/lib/sentry/opentelemetry/span_processor.rb 100.00% <100.00%> (ø)
...y/spec/sentry/opentelemetry/span_processor_spec.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@solnic solnic force-pushed the solnic/2338-opentelemetry-connect-spans-from-sdk-are-included-in-traces branch from b3a18fd to f315a15 Compare August 8, 2024 12:00
@solnic solnic requested a review from sl0thentr0py August 8, 2024 12:13
@sl0thentr0py sl0thentr0py merged commit 278316c into master Aug 8, 2024
126 checks passed
@sl0thentr0py sl0thentr0py deleted the solnic/2338-opentelemetry-connect-spans-from-sdk-are-included-in-traces branch August 8, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTelemetry: "connect" spans from SDK are included in traces
2 participants