Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Sample): Remove/Replace deprecated functions #4597

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Feb 25, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

configureScope was gone since Sentry JS SDK 8.0.0 so I replaced it with getGlobalScope.
getAttachments was silently removed since 8.0.0 so I removed it from the sample app.
image

💡 Motivation and Context

It fixes their original behavior, and since getattachment was removed, there is no point in keeping this option.

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

Copy link
Contributor

github-actions bot commented Feb 25, 2025

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 437.25 ms 477.20 ms 39.95 ms
Size 17.75 MiB 20.12 MiB 2.37 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
c6f01ea 486.20 ms 486.98 ms 0.77 ms
d16beca 448.87 ms 447.20 ms -1.67 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
a0b0298 427.50 ms 428.10 ms 0.60 ms
43e66e0 373.32 ms 366.57 ms -6.75 ms
6707be9 445.04 ms 464.24 ms 19.20 ms
6a667d6 485.15 ms 541.62 ms 56.47 ms
b6f8ea2 472.49 ms 469.60 ms -2.89 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
db44eaf 437.65 ms 436.06 ms -1.59 ms

App size

Revision Plain With Sentry Diff
c6f01ea 17.74 MiB 20.10 MiB 2.36 MiB
d16beca 17.74 MiB 20.10 MiB 2.36 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
a0b0298 17.75 MiB 20.12 MiB 2.37 MiB
43e66e0 17.74 MiB 20.09 MiB 2.35 MiB
6707be9 17.75 MiB 20.11 MiB 2.37 MiB
6a667d6 17.75 MiB 20.11 MiB 2.36 MiB
b6f8ea2 17.75 MiB 20.11 MiB 2.36 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
db44eaf 17.74 MiB 20.08 MiB 2.35 MiB

Previous results on branch: lz/sample-remove-deprecated

Startup times

Revision Plain With Sentry Diff
5d41c3f 364.66 ms 431.49 ms 66.83 ms

App size

Revision Plain With Sentry Diff
5d41c3f 17.75 MiB 20.12 MiB 2.37 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.63 ms 1232.74 ms 9.11 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
40c35c5+dirty 1211.31 ms 1217.71 ms 6.40 ms
5fe8312+dirty 1222.06 ms 1220.56 ms -1.51 ms
94fc925+dirty 1231.12 ms 1223.85 ms -7.27 ms
cdc3945+dirty 1202.43 ms 1223.65 ms 21.23 ms
3f05680+dirty 1229.37 ms 1235.04 ms 5.68 ms
77680ec+dirty 1231.81 ms 1238.35 ms 6.54 ms
3aecc61+dirty 1237.75 ms 1237.42 ms -0.33 ms
07e58c9+dirty 1226.02 ms 1228.35 ms 2.33 ms
e22745e+dirty 1222.73 ms 1224.98 ms 2.25 ms
e1ea4a8+dirty 1233.49 ms 1237.71 ms 4.22 ms

App size

Revision Plain With Sentry Diff
40c35c5+dirty 2.63 MiB 3.70 MiB 1.07 MiB
5fe8312+dirty 2.63 MiB 3.70 MiB 1.06 MiB
94fc925+dirty 2.63 MiB 3.69 MiB 1.05 MiB
cdc3945+dirty 2.63 MiB 3.75 MiB 1.12 MiB
3f05680+dirty 2.63 MiB 3.74 MiB 1.11 MiB
77680ec+dirty 2.36 MiB 3.10 MiB 753.42 KiB
3aecc61+dirty 2.36 MiB 3.12 MiB 778.58 KiB
07e58c9+dirty 2.36 MiB 3.10 MiB 752.28 KiB
e22745e+dirty 2.36 MiB 3.10 MiB 752.32 KiB
e1ea4a8+dirty 2.36 MiB 3.10 MiB 752.31 KiB

Copy link
Contributor

github-actions bot commented Feb 25, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.63 ms 1223.69 ms 2.06 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
57448c5+dirty 1244.65 ms 1249.20 ms 4.55 ms
6c56eb1+dirty 1240.96 ms 1243.41 ms 2.45 ms
30189be+dirty 1228.73 ms 1219.06 ms -9.67 ms
4cc5c27+dirty 1220.43 ms 1215.13 ms -5.30 ms
d43a46b+dirty 1223.31 ms 1230.92 ms 7.61 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
2dc8f22+dirty 1215.43 ms 1206.68 ms -8.75 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
acadc0f+dirty 1271.12 ms 1272.28 ms 1.16 ms
9a3ca65+dirty 1276.40 ms 1279.14 ms 2.74 ms

App size

Revision Plain With Sentry Diff
57448c5+dirty 2.92 MiB 3.66 MiB 756.65 KiB
6c56eb1+dirty 2.92 MiB 3.67 MiB 772.48 KiB
30189be+dirty 3.19 MiB 4.26 MiB 1.08 MiB
4cc5c27+dirty 2.92 MiB 3.61 MiB 705.47 KiB
d43a46b+dirty 2.92 MiB 3.64 MiB 740.29 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
2dc8f22+dirty 3.19 MiB 4.25 MiB 1.06 MiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
acadc0f+dirty 2.92 MiB 3.39 MiB 487.34 KiB
9a3ca65+dirty 2.92 MiB 3.37 MiB 464.32 KiB

Previous results on branch: lz/sample-remove-deprecated

Startup times

Revision Plain With Sentry Diff
5d41c3f+dirty 1228.12 ms 1228.06 ms -0.06 ms

App size

Revision Plain With Sentry Diff
5d41c3f+dirty 3.19 MiB 4.32 MiB 1.13 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 Thank you for cleaning this up Lucas 🙇

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 375.80 ms 361.94 ms -13.86 ms
Size 7.15 MiB 8.39 MiB 1.23 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
a0df630+dirty 360.73 ms 406.64 ms 45.91 ms
30189be+dirty 362.02 ms 386.80 ms 24.78 ms
83f6f6c+dirty 442.82 ms 487.48 ms 44.66 ms
8e80789+dirty 464.48 ms 551.10 ms 86.63 ms
7143e6f+dirty 338.60 ms 374.92 ms 36.32 ms
7e87527+dirty 406.35 ms 465.24 ms 58.90 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
e540498+dirty 408.56 ms 480.00 ms 71.44 ms
b6f8ea2+dirty 397.51 ms 457.40 ms 59.88 ms
8bda0cc+dirty 383.08 ms 417.40 ms 34.32 ms

App size

Revision Plain With Sentry Diff
a0df630+dirty 7.15 MiB 8.38 MiB 1.23 MiB
30189be+dirty 7.15 MiB 8.38 MiB 1.23 MiB
83f6f6c+dirty 7.15 MiB 8.37 MiB 1.22 MiB
8e80789+dirty 7.15 MiB 8.37 MiB 1.22 MiB
7143e6f+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7e87527+dirty 7.15 MiB 8.38 MiB 1.23 MiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
e540498+dirty 7.15 MiB 8.38 MiB 1.23 MiB
b6f8ea2+dirty 7.15 MiB 8.38 MiB 1.23 MiB
8bda0cc+dirty 7.15 MiB 8.38 MiB 1.23 MiB

Previous results on branch: lz/sample-remove-deprecated

Startup times

Revision Plain With Sentry Diff
5d41c3f+dirty 386.64 ms 397.00 ms 10.36 ms

App size

Revision Plain With Sentry Diff
5d41c3f+dirty 7.15 MiB 8.39 MiB 1.23 MiB

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) February 27, 2025 12:17
@lucas-zimerman lucas-zimerman merged commit 86818c7 into main Feb 27, 2025
62 of 63 checks passed
@lucas-zimerman lucas-zimerman deleted the lz/sample-remove-deprecated branch February 27, 2025 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants