Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish/6.4.0 #4344

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Publish/6.4.0 #4344

merged 5 commits into from
Dec 10, 2024

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Dec 5, 2024 •
edited
Loading

This PR merges publish branch back to main. Ensure main contains the latest published version.

#skip-changelog

@krystofwoldrich krystofwoldrich deleted the publish/6.4.0 branch December 5, 2024 15:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.22 ms 428.17 ms 30.95 ms
Size 7.15 MiB 8.37 MiB 1.22 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
4cc5c27+dirty 398.36 ms 452.50 ms 54.14 ms
e73d82f+dirty 377.67 ms 407.06 ms 29.39 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
eb1e19f+dirty 391.37 ms 418.27 ms 26.90 ms
c639edf+dirty 363.39 ms 414.78 ms 51.39 ms
31fcca2+dirty 366.64 ms 395.78 ms 29.14 ms
690220d+dirty 492.10 ms 473.88 ms -18.23 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
a989877+dirty 383.04 ms 400.92 ms 17.88 ms

App size

Revision Plain With Sentry Diff
4cc5c27+dirty 7.15 MiB 8.22 MiB 1.07 MiB
e73d82f+dirty 7.15 MiB 8.34 MiB 1.19 MiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
eb1e19f+dirty 7.15 MiB 8.35 MiB 1.20 MiB
c639edf+dirty 7.15 MiB 8.35 MiB 1.20 MiB
31fcca2+dirty 7.15 MiB 8.18 MiB 1.03 MiB
690220d+dirty 7.15 MiB 8.36 MiB 1.21 MiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
a989877+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Previous results on branch: publish/6.4.0

Startup times

Revision Plain With Sentry Diff
6c1071e+dirty 408.44 ms 458.07 ms 49.63 ms

App size

Revision Plain With Sentry Diff
6c1071e+dirty 7.15 MiB 8.37 MiB 1.22 MiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1223.43 ms 1233.06 ms 9.63 ms
Size 2.36 MiB 3.11 MiB 759.80 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baa882f+dirty 1218.00 ms 1227.04 ms 9.04 ms
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
0db0c72+dirty 1275.02 ms 1285.84 ms 10.82 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
2ec71da+dirty 1225.85 ms 1231.57 ms 5.72 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
31fcca2+dirty 1209.17 ms 1216.21 ms 7.04 ms
690220d+dirty 1228.27 ms 1233.55 ms 5.29 ms

App size

Revision Plain With Sentry Diff
baa882f+dirty 2.36 MiB 3.08 MiB 731.91 KiB
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
0db0c72+dirty 2.36 MiB 2.84 MiB 487.01 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
2ec71da+dirty 2.36 MiB 3.13 MiB 784.66 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
31fcca2+dirty 2.36 MiB 2.90 MiB 552.95 KiB
690220d+dirty 2.36 MiB 3.10 MiB 753.57 KiB

Previous results on branch: publish/6.4.0

Startup times

Revision Plain With Sentry Diff
6c1071e+dirty 1235.06 ms 1231.10 ms -3.96 ms

App size

Revision Plain With Sentry Diff
6c1071e+dirty 2.36 MiB 3.11 MiB 759.83 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1238.31 ms 1226.80 ms -11.51 ms
Size 2.92 MiB 3.67 MiB 772.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
baa882f+dirty 1235.48 ms 1229.02 ms -6.46 ms
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
0db0c72+dirty 1258.88 ms 1262.52 ms 3.64 ms
76d1baf+dirty 1245.00 ms 1257.76 ms 12.76 ms
2ec71da+dirty 1230.29 ms 1239.50 ms 9.21 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms
31fcca2+dirty 1222.04 ms 1226.51 ms 4.47 ms
690220d+dirty 1227.45 ms 1221.67 ms -5.78 ms

App size

Revision Plain With Sentry Diff
baa882f+dirty 2.92 MiB 3.64 MiB 738.56 KiB
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
0db0c72+dirty 2.92 MiB 3.40 MiB 492.71 KiB
76d1baf+dirty 2.92 MiB 3.38 MiB 475.74 KiB
2ec71da+dirty 2.92 MiB 3.69 MiB 791.06 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB
31fcca2+dirty 2.92 MiB 3.46 MiB 557.31 KiB
690220d+dirty 2.92 MiB 3.66 MiB 758.77 KiB

Previous results on branch: publish/6.4.0

Startup times

Revision Plain With Sentry Diff
6c1071e+dirty 1239.47 ms 1244.15 ms 4.68 ms

App size

Revision Plain With Sentry Diff
6c1071e+dirty 2.92 MiB 3.67 MiB 772.42 KiB

@krystofwoldrich krystofwoldrich restored the publish/6.4.0 branch December 5, 2024 19:46
@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 5, 2024 19:47
@krystofwoldrich
Copy link
Member Author

Closed by accident.

antonis
antonis approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 457.41 ms 449.56 ms -7.85 ms
Size 17.74 MiB 20.09 MiB 2.35 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
13f280b 486.16 ms 472.45 ms -13.71 ms
c639edf 466.48 ms 489.57 ms 23.09 ms
52c0562 453.04 ms 434.71 ms -18.33 ms
5446992 403.40 ms 426.70 ms 23.30 ms
5a22220 412.38 ms 447.35 ms 34.97 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms
4297324 536.61 ms 542.48 ms 5.87 ms
0db0c72 372.12 ms 386.00 ms 13.88 ms
457e29f 398.10 ms 421.39 ms 23.29 ms

App size

Revision Plain With Sentry Diff
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB
c639edf 17.74 MiB 20.08 MiB 2.34 MiB
52c0562 17.73 MiB 20.11 MiB 2.38 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB
5a22220 17.73 MiB 19.93 MiB 2.20 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB
4297324 17.74 MiB 20.08 MiB 2.34 MiB
0db0c72 17.73 MiB 19.75 MiB 2.02 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB

lucas-zimerman
lucas-zimerman approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lucas-zimerman lucas-zimerman enabled auto-merge (squash) December 10, 2024 11:19
@lucas-zimerman lucas-zimerman merged commit ddc0552 into main Dec 10, 2024
53 of 54 checks passed
@lucas-zimerman lucas-zimerman deleted the publish/6.4.0 branch December 10, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonis antonis antonis approved these changes

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krystofwoldrich @antonis @lucas-zimerman @getsentry-bot