Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Hotfix: update Cocoa SDK from 8.29.1 to 8.36.0 #4102

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Sep 19, 2024

Bumps Cocoa SDK version from 8.29.1 to 8.36.0 for hotfix release 5.24.3.
Also:

Changelog

8.36.0

Features

Fixes

8.35.1

Fixes

8.35.0

Features

Fixes

8.34.0

Features

Fixes

8.33.0

Note: Due to a bug (#4280) introduced in this release, we recommend upgrading to 8.35.0 or newer.


This release fixes a bug (#4230) that we introduced with a refactoring (#4101) released in 8.30.1.
This bug caused unhandled/crash events to have the unhandled property and mach info missing, which is required for release health to show events in the unhandled tab. It's essential to mention that this bug doesn't impact release health statistics, such as crash-free session or user rates.

Features

Fixes

Improvements

8.32.0

Features

Fixes

Features

Deprecated

8.31.1

Fixes

8.31.0

Features

Fixes

8.30.1

Fixes

8.30.0

Features

Fixes

@antonis antonis marked this pull request as draft September 19, 2024 08:50
@antonis antonis marked this pull request as ready for review September 19, 2024 09:25
Copy link
Contributor

github-actions bot commented Sep 19, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 393.35 ms 433.96 ms 40.61 ms
Size 7.15 MiB 8.21 MiB 1.07 MiB

Copy link
Contributor

github-actions bot commented Sep 19, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.09 ms 1236.17 ms 1.08 ms
Size 2.92 MiB 3.63 MiB 733.79 KiB

CHANGELOG.md Outdated Show resolved Hide resolved
@antonis antonis requested a review from kahest September 19, 2024 09:48
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

github-actions bot commented Sep 19, 2024

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1231.42 ms 1235.25 ms 3.83 ms
Size 2.36 MiB 3.07 MiB 726.37 KiB

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 517.20 ms 518.84 ms 1.64 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

@antonis antonis marked this pull request as draft September 19, 2024 10:40
@antonis
Copy link
Collaborator Author

antonis commented Sep 19, 2024

Adding some notes on the failing CI tests:

  • Build RN 0.73.2 new hermes android production no and Build RN 0.73.2 legacy hermes android production no should be related with the sourceMapString is not a function fix
  • Build legacy ios dev no-frameworks, Build legacy ios production no-frameworks, Build new ios dev no-frameworks, Build new ios production no-frameworks, Build RN 0.73.2 legacy hermes ios production no, Build RN 0.73.2 new hermes ios production no should be related with the fix CI flipper error
  • Build RN 0.73.2 legacy hermes ios production static, Build RN 0.73.2 legacy hermes ios production dynamic, Build RN 0.73.2 new hermes ios production static could also be related with the above.
  • the End-to-End Tests / metrics (legacy, android) (pull_request), End-to-End Tests / metrics (new, ios) (pull_request) is a known issue

(cherry picked from commit f5fb735)
(cherry picked from commit 434f32e)
Add the unreleased section to let the release script create the hotfix version section

Co-authored-by: Karl Heinz Struggl <kahest@users.noreply.github.com>
(cherry picked from commit 2116b5e)
@antonis antonis force-pushed the antonis/bump-cocoa-to-8.36.0 branch from 2ab5534 to a0e0d80 Compare September 19, 2024 14:24
@antonis antonis force-pushed the antonis/bump-cocoa-to-8.36.0 branch from a0e0d80 to b2c1497 Compare September 19, 2024 15:02
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
The tests should be passing before merging, but other than that the PR looks good!

@lucas-zimerman
Copy link
Collaborator

lucas-zimerman commented Sep 19, 2024

@antonis I saw the following error messages on the CI tests:

error Your lockfile needs to be updated, but yarn was run with `--frozen-lockfile`.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Could you try updating the branch locally and update (yarn install) the samples and the SDK project?

Let me know if you need any help

@antonis antonis marked this pull request as ready for review September 20, 2024 05:03
@antonis antonis merged commit 92079a0 into hotfix/5.24.3 Sep 20, 2024
58 of 59 checks passed
@antonis antonis deleted the antonis/bump-cocoa-to-8.36.0 branch September 20, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants