Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android compileSdkVersion and buildToolsVersion #343

Closed
wants to merge 2 commits into from
Closed

Update Android compileSdkVersion and buildToolsVersion #343

wants to merge 2 commits into from

Conversation

anandprabhu
Copy link

The current Android compileSdkVersion, targetSdkVersion and buildToolsVersion uses the older but default version provided by the react-native init tool. However updating to the latest version might support possible Android build issues in scenarios where other third-party libraries require the root project to have their compiledSdkVersion and buildToolsVersion to be 25 or above. Have tested these changes in our own project and seems to be working fine without any issues.

Update the compileSdkVersion to 26 and buildToolVersion to 26.0.2
…ersion

Update Android compileSdkVersion and buildToolsVersion
@anandprabhu anandprabhu requested a review from HazAT as a code owner February 1, 2018 09:19
@anandprabhu
Copy link
Author

The below issue mentions the need to update the SDK version to 26 in detail.

facebook/react-native#17287

@HazAT
Copy link
Member

HazAT commented Feb 1, 2018

First of all, thank you for your PR.
We already had several PRs bumping the build tools version, while I would love to merge it and already did once, we will bump it as soon as facebook raises their minimum requirement.
Until then people would need to bump it on their own.

@HazAT
Copy link
Member

HazAT commented May 16, 2018

As soon this facebook/react-native#17741 is merged we can merge this PR.

@GertjanReynaert
Copy link

GertjanReynaert commented Jul 4, 2018

Can this PR be merged please? I'm currently getting this error when trying to build our app for android:

      > The SDK Build Tools revision (23.0.1) is too low for project ':react-native-sentry'. Minimum required is 25.0.0

This is on the newly released react-native 56, which upgrades a few android dependencies, so I suspect this pr will fix that issue.

cc @HazAT

@CptFabulouso
Copy link

CptFabulouso commented Jul 16, 2018

since RN 0.56.0 this is default gradle configuration

    buildToolsVersion = "26.0.3"
    minSdkVersion = 16
    compileSdkVersion = 26
    targetSdkVersion = 26
    supportLibVersion = "26.1.0"

can we update this appropriately and merge?
oh, didn't notice previous comment..

@se-bastiaan
Copy link

Please note that the build tools in this pull request are set to 26.0.2. The latest version is 26.0.3.

@HazAT
Copy link
Member

HazAT commented Jul 30, 2018

Thank you again for the PR, I am closing this one in favor of #452

@HazAT HazAT closed this Jul 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants