Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(changelog): Correct HTTP Client Errors entry and add an example #2942

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Make a better changelog.

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@krystofwoldrich krystofwoldrich enabled auto-merge (squash) March 30, 2023 12:02
@krystofwoldrich krystofwoldrich merged commit 3bc3e52 into main Mar 30, 2023
@krystofwoldrich krystofwoldrich deleted the kw-fix-changelog branch March 30, 2023 12:06
@github-actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 353.04 ms 358.00 ms 4.96 ms
Size 17.73 MiB 19.75 MiB 2.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
9a3ca65+dirty 326.93 ms 330.14 ms 3.21 ms
52a8031+dirty 311.55 ms 321.37 ms 9.82 ms
70caa60+dirty 299.00 ms 321.02 ms 22.02 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9a3ca65+dirty 17.73 MiB 20.04 MiB 2.31 MiB
52a8031+dirty 17.73 MiB 20.04 MiB 2.31 MiB
70caa60+dirty 17.73 MiB 19.75 MiB 2.01 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB

@github-actions
Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1278.92 ms 1281.73 ms 2.81 ms
Size 2.36 MiB 2.83 MiB 480.36 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms
86d6d2c+dirty 1267.55 ms 1286.21 ms 18.66 ms
76d1baf+dirty 1244.10 ms 1268.52 ms 24.42 ms
9a3ca65+dirty 1247.06 ms 1274.58 ms 27.52 ms
52a8031+dirty 1280.88 ms 1289.78 ms 8.90 ms
70caa60+dirty 1218.27 ms 1230.30 ms 12.03 ms
15c80ab+dirty 1223.74 ms 1228.96 ms 5.22 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB
86d6d2c+dirty 2.36 MiB 2.82 MiB 462.82 KiB
76d1baf+dirty 2.36 MiB 2.82 MiB 469.45 KiB
9a3ca65+dirty 2.36 MiB 2.82 MiB 462.89 KiB
52a8031+dirty 2.36 MiB 2.82 MiB 469.44 KiB
70caa60+dirty 2.36 MiB 2.83 MiB 479.27 KiB
15c80ab+dirty 2.36 MiB 2.83 MiB 474.49 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB

@github-actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 328.75 ms 343.74 ms 14.99 ms
Size 7.15 MiB 8.03 MiB 903.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
8900e1a+dirty 371.40 ms 377.70 ms 6.31 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
76d1baf+dirty 339.02 ms 408.65 ms 69.63 ms
9a3ca65+dirty 344.96 ms 358.92 ms 13.96 ms
52a8031+dirty 330.72 ms 358.76 ms 28.03 ms
70caa60+dirty 308.83 ms 393.06 ms 84.23 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms

App size

Revision Plain With Sentry Diff
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
8900e1a+dirty 7.15 MiB 8.03 MiB 901.79 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
76d1baf+dirty 7.15 MiB 8.09 MiB 964.41 KiB
9a3ca65+dirty 7.15 MiB 8.09 MiB 962.83 KiB
52a8031+dirty 7.15 MiB 8.09 MiB 965.95 KiB
70caa60+dirty 7.15 MiB 8.03 MiB 901.79 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants