feat(sdk): Add in_foreground to event app context
#2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d760caf+dirty | 1258.76 ms | 1292.66 ms | 33.90 ms |
| b868b53+dirty | 1253.68 ms | 1253.94 ms | 0.26 ms |
| d091239+dirty | 1261.62 ms | 1275.80 ms | 14.17 ms |
| 58ae930+dirty | 1266.80 ms | 1273.79 ms | 6.99 ms |
| 34dc259+dirty | 1283.72 ms | 1289.30 ms | 5.58 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| d760caf+dirty | 2.92 MiB | 3.37 MiB | 462.90 KiB |
| b868b53+dirty | 2.92 MiB | 3.30 MiB | 387.19 KiB |
| d091239+dirty | 2.92 MiB | 3.30 MiB | 387.22 KiB |
| 58ae930+dirty | 2.92 MiB | 3.37 MiB | 464.04 KiB |
| 34dc259+dirty | 2.92 MiB | 3.37 MiB | 463.96 KiB |
| nativeContext = nativeContext || {}; | ||
| nativeContext.app = { | ||
| ...nativeContext.app, | ||
| in_foreground: AppState.currentState === 'active', |
There was a problem hiding this comment.
Doesn't it need to be set to "false" at some point too? Or are you passing the nativeContext to the native SDKs and they set it for you?
There was a problem hiding this comment.
The in_foreground is merged into what I get from native SDKs. As I think the value that RN reports is important for RN devs.
If the AppState.currentState === 'active' => true, else false.
Thanks for the comment I've added a test to make it clear how it works.
marandaneto
reviewed
Feb 20, 2023
in_foreground to event app context
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps