chore(deps): update Cocoa SDK to v8.0.0 #2707

krystofwoldrich · 2022-12-19T12:32:43Z

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Upgrade to the sentry-cocoa v8

💡 Motivation and Context

closes: #2679

💚 How did you test it?

📝 Checklist

I reviewed submitted code
I added tests to verify changes
All tests passing
No breaking changes

🔮 Next steps

github-actions · 2022-12-19T12:52:50Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	448.43 ms	485.11 ms	36.68 ms
Size	17.73 MiB	20.09 MiB	2.35 MiB

Baseline results on branch: 5.0.0

Startup times

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	339.52 ms	369.84 ms	30.32 ms
`d091239`+dirty	425.61 ms	447.11 ms	21.50 ms

App size

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	17.73 MiB	19.95 MiB	2.22 MiB
`d091239`+dirty	17.73 MiB	19.95 MiB	2.22 MiB

Previous results on branch: cocoa-v8

Startup times

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	368.49 ms	387.31 ms	18.82 ms
`c0c38f3`+dirty	389.12 ms	402.18 ms	13.06 ms

App size

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	17.73 MiB	19.95 MiB	2.22 MiB
`c0c38f3`+dirty	17.73 MiB	19.95 MiB	2.22 MiB

github-actions · 2022-12-19T13:19:26Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1255.46 ms	1266.96 ms	11.50 ms
Size	2.36 MiB	2.75 MiB	395.43 KiB

Baseline results on branch: 5.0.0

Startup times

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	1274.90 ms	1305.68 ms	30.78 ms
`d091239`+dirty	1251.49 ms	1276.75 ms	25.26 ms

App size

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	2.36 MiB	2.74 MiB	384.64 KiB
`d091239`+dirty	2.36 MiB	2.74 MiB	384.64 KiB

Previous results on branch: cocoa-v8

Startup times

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	1253.00 ms	1271.48 ms	18.48 ms
`c0c38f3`+dirty	1288.32 ms	1291.94 ms	3.62 ms

App size

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	2.36 MiB	2.75 MiB	395.45 KiB
`c0c38f3`+dirty	2.36 MiB	2.75 MiB	395.44 KiB

github-actions · 2022-12-19T13:28:30Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1302.43 ms	1307.62 ms	5.19 ms
Size	2.92 MiB	3.31 MiB	399.25 KiB

Baseline results on branch: 5.0.0

Startup times

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	1253.68 ms	1253.94 ms	0.26 ms
`d091239`+dirty	1261.62 ms	1275.80 ms	14.17 ms

App size

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	2.92 MiB	3.30 MiB	387.19 KiB
`d091239`+dirty	2.92 MiB	3.30 MiB	387.22 KiB

Previous results on branch: cocoa-v8

Startup times

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	1225.57 ms	1249.94 ms	24.37 ms
`c0c38f3`+dirty	1276.96 ms	1292.92 ms	15.96 ms

App size

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	2.92 MiB	3.31 MiB	399.25 KiB
`c0c38f3`+dirty	2.92 MiB	3.31 MiB	399.20 KiB

ios/Private/SentryOptions+RNOptions.mm

github-actions · 2022-12-20T11:34:18Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	274.00 ms	290.29 ms	16.29 ms
Size	7.15 MiB	8.13 MiB	1010.72 KiB

Baseline results on branch: 5.0.0

Startup times

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	321.42 ms	342.74 ms	21.32 ms
`d091239`+dirty	340.16 ms	366.42 ms	26.26 ms

App size

Revision	Plain	With Sentry	Diff
`b868b53`+dirty	7.15 MiB	8.00 MiB	874.27 KiB
`d091239`+dirty	7.15 MiB	8.00 MiB	874.38 KiB

Previous results on branch: cocoa-v8

Startup times

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	302.81 ms	328.10 ms	25.29 ms
`c0c38f3`+dirty	327.82 ms	359.53 ms	31.71 ms

App size

Revision	Plain	With Sentry	Diff
`738ca30`+dirty	7.15 MiB	8.00 MiB	874.27 KiB
`c0c38f3`+dirty	7.15 MiB	8.00 MiB	874.27 KiB

Remove unused RNSentry project

github-actions · 2023-01-11T00:10:49Z

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

ios/Private/SentryOptions+RNOptions.mm

marandaneto · 2023-01-12T08:23:50Z

@krystofwoldrich upgrade to the latest RC and double check the list again.

…to cocoa-v8

philipphofmann · 2023-01-18T18:36:46Z

After updating, please adapt the docs on enableOutOfMemoryTracking accordingly that it's no longer available and is now renamed to enableWatchdogTerminationTracking.

krystofwoldrich · 2023-01-19T13:29:20Z

Docs changes here:

Add react native v5 changes sentry-docs#6115

marandaneto · 2023-01-20T16:30:30Z

@krystofwoldrich is this ready to be reviewed?

krystofwoldrich · 2023-01-23T08:52:37Z

@marandaneto Yes, it's ready to be reviewed. Only metrics are failing, because the time with Sentry is smaller than the time without Sentry.

sample/src/App.tsx

Initial cocoa v8 support

ce32e2c

krystofwoldrich requested a review from marandaneto as a code owner December 19, 2022 12:32

krystofwoldrich changed the title ~~chore(deps): update Cocoa SDK to v8.0.0-beta.4 (#2699)~~ chore(deps): update Cocoa SDK to v8.0.0-beta.4 Dec 19, 2022

Add SentryOptions+RNOptions tests

3f7f0b9

marandaneto reviewed Dec 20, 2022

View reviewed changes

ios/Private/SentryOptions+RNOptions.mm Outdated Show resolved Hide resolved

krystofwoldrich added 4 commits December 20, 2022 14:00

Add xcode native test to ci

1d8b642

Add only active arch

9fecc28

Add app js deps install

a08fb3a

Add minimal RNSentryTester xcode project

351812c

Remove unused RNSentry project

github-actions bot added the Status: Stale label Jan 11, 2023

Merge branch '5.0.0' into cocoa-v8

422c6ef

github-actions bot removed the Status: Stale label Jan 12, 2023

marandaneto reviewed Jan 12, 2023

View reviewed changes

ios/Private/SentryOptions+RNOptions.mm Outdated Show resolved Hide resolved

marandaneto reviewed Jan 12, 2023

View reviewed changes

ios/Private/SentryOptions+RNOptions.mm Outdated Show resolved Hide resolved

web-flow and others added 3 commits January 17, 2023 03:02

chore: update scripts/update-cocoa.sh to 8.0.0

7288c8c

Merge remote-tracking branch 'origin/5.0.0' into cocoa-v8

2858233

Merge remote-tracking branch 'origin/deps/scripts/update-cocoa.sh' in…

dea06fb

…to cocoa-v8

krystofwoldrich added 2 commits January 19, 2023 13:27

Remove RNSentryPrivate, refactor options and add tests

92abd1d

Merge remote-tracking branch 'origin/5.0.0' into cocoa-v8

e0e7eae

krystofwoldrich changed the title ~~chore(deps): update Cocoa SDK to v8.0.0-beta.4~~ chore(deps): update Cocoa SDK to v8.0.0 Jan 19, 2023

Change to the new cocoa v8 naming

6ec98de

Merge branch '5.0.0' into cocoa-v8

ce5b282

krystofwoldrich requested a review from marandaneto January 20, 2023 09:27

marandaneto mentioned this pull request Jan 20, 2023

Add View Hierarchy #2708

Merged

11 tasks

Merge branch '5.0.0' into cocoa-v8

62e8b18

marandaneto reviewed Jan 23, 2023

View reviewed changes

sample/src/App.tsx Outdated Show resolved Hide resolved

marandaneto approved these changes Jan 23, 2023

View reviewed changes

krystofwoldrich added 2 commits January 23, 2023 16:10

Do not add hint to sample app

d715e3c

Remove CI change

fd5b717

krystofwoldrich merged commit 20f0f0d into 5.0.0 Jan 23, 2023

krystofwoldrich deleted the cocoa-v8 branch January 23, 2023 15:14

bruno-garcia mentioned this pull request Jun 26, 2023

build(deps): bump Sentry for iOS (sentry-cocoa) to 8.8.0 getsentry/sentry-capacitor#397

Merged

krystofwoldrich mentioned this pull request Apr 30, 2024

Add tests for the Native Bridges #1874

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): update Cocoa SDK to v8.0.0 #2707

chore(deps): update Cocoa SDK to v8.0.0 #2707

krystofwoldrich commented Dec 19, 2022

github-actions bot commented Dec 19, 2022 •

edited

Loading

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 19, 2022 •

edited

Loading

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 19, 2022 •

edited

Loading

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 20, 2022 •

edited

Loading

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Jan 11, 2023

marandaneto commented Jan 12, 2023

philipphofmann commented Jan 18, 2023

krystofwoldrich commented Jan 19, 2023

marandaneto commented Jan 20, 2023

krystofwoldrich commented Jan 23, 2023 •

edited

Loading

chore(deps): update Cocoa SDK to v8.0.0 #2707

chore(deps): update Cocoa SDK to v8.0.0 #2707

Conversation

krystofwoldrich commented Dec 19, 2022

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

github-actions bot commented Dec 19, 2022 • edited Loading

Android (legacy) Performance metrics 🚀

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 19, 2022 • edited Loading

iOS (legacy) Performance metrics 🚀

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 19, 2022 • edited Loading

iOS (new) Performance metrics 🚀

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Dec 20, 2022 • edited Loading

Android (new) Performance metrics 🚀

Baseline results on branch: 5.0.0

Startup times

App size

Previous results on branch: cocoa-v8

Startup times

App size

github-actions bot commented Jan 11, 2023

marandaneto commented Jan 12, 2023

philipphofmann commented Jan 18, 2023

krystofwoldrich commented Jan 19, 2023

marandaneto commented Jan 20, 2023

krystofwoldrich commented Jan 23, 2023 • edited Loading

github-actions bot commented Dec 19, 2022 •

edited

Loading

github-actions bot commented Dec 19, 2022 •

edited

Loading

github-actions bot commented Dec 19, 2022 •

edited

Loading

github-actions bot commented Dec 20, 2022 •

edited

Loading

krystofwoldrich commented Jan 23, 2023 •

edited

Loading