-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Attach Screenshot Option #2373
Conversation
Thanks @PaitoAnderson |
|
Thanks @marandaneto for all your work figuring out why this didn't work as I had hoped; based on the changes that need to happen before this relatively simple PR can be merged would you rather I closed this PR or leave it open? |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Replaced by #2610 |
Fixes #2362
📢 Type of change
📜 Description
Adds a
attachScreenshot
option that sets theattachScreenshot
in cocoa project and callssetAttachScreenshot
in java project.💡 Motivation and Context
Excited about using the new Sentry screenshot feature in React Native projects.
💚 How did you test it?
Ran the sample projects.
iOS:
![image](https://user-images.githubusercontent.com/4108718/179298024-1caeaf5c-d719-48d2-bbc9-8784ac164147.png)
Android:
![image](https://user-images.githubusercontent.com/4108718/179300831-3d1cb9b3-80bc-464a-b694-57b47222ed9d.png)
(Not sure what I have to do to trigger a screenshot, didn't work for me, but did verify the setting was indeed set at init)
📝 Checklist
🔮 Next steps