Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Attach Screenshot Option #2373

Closed
wants to merge 3 commits into from

Conversation

PaitoAnderson
Copy link
Contributor

Fixes #2362

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds a attachScreenshot option that sets the attachScreenshot in cocoa project and calls setAttachScreenshot in java project.

💡 Motivation and Context

Excited about using the new Sentry screenshot feature in React Native projects.

💚 How did you test it?

Ran the sample projects.

iOS:
image

Android:
image
(Not sure what I have to do to trigger a screenshot, didn't work for me, but did verify the setting was indeed set at init)

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

CHANGELOG.md Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

Thanks @PaitoAnderson
I'll check what's going on on Android.

@marandaneto marandaneto changed the base branch from main to 5.0.0 July 25, 2022 08:15
@marandaneto marandaneto marked this pull request as draft July 25, 2022 13:32
@marandaneto
Copy link
Contributor

Thanks @PaitoAnderson I'll check what's going on on Android.

#2362 (comment)

@PaitoAnderson
Copy link
Contributor Author

Thanks @marandaneto for all your work figuring out why this didn't work as I had hoped; based on the changes that need to happen before this relatively simple PR can be merged would you rather I closed this PR or leave it open?

@github-actions
Copy link
Contributor

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@marandaneto
Copy link
Contributor

Replaced by #2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach screenshot
2 participants