Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing DSN to BrowserClient #2294

Merged
merged 5 commits into from
Jun 20, 2022
Merged

Add missing DSN to BrowserClient #2294

merged 5 commits into from
Jun 20, 2022

Conversation

lucas-zimerman
Copy link
Collaborator

This fixes the warning that it was missing the DSN, despite being set by the user,

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing
  • No breaking changes

🔮 Next steps

This fixes the warning that it was missing the DSN, despite being set by the user,
@lucas-zimerman lucas-zimerman marked this pull request as ready for review June 15, 2022 21:35
src/js/client.ts Outdated Show resolved Hide resolved
@marandaneto
Copy link
Contributor

Thanks @lucas-zimerman

@marandaneto marandaneto enabled auto-merge (squash) June 20, 2022 06:43
@marandaneto marandaneto merged commit 76ccbac into main Jun 20, 2022
@marandaneto marandaneto deleted the fix/dsn-warning branch June 20, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants