-
-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Sentry JavaScript 7 #2250
Bump Sentry JavaScript 7 #2250
Conversation
@marandaneto Should we drop the support of Severity in favor of SeverityLevel, or keep both? |
@AbhiPrasad and @lobsterkatie Would you be so kind to do a quick/high-level review in this PR since you all have worked on the JS 7 major release? otherwise, I'd need to learn all the breaking changes just for the review. |
This change likely requires a major bump, so I'd rather do what the JS SDK 7.x does. |
Please drop support of Severity in favor of SeverityLevel! cc @getsentry/team-web-sdk-frontend in general, please lets get more eyes on this! |
Also - now that the official release has been cut, we now have a proper final CHANGELOG: https://github.com/getsentry/sentry-javascript/releases/tag/7.0.0 |
Android e2e seems broken, but not due to this PR, see a test that ran on the release of 3.4.3: https://github.com/getsentry/sentry-react-native/runs/6703000870?check_suite_focus=true EDIT: The Code for consuming Envelopes seems broken on Android, I'll give it a look on it. |
The e2e test is on iOS, it's an issue with the GH action environments, it breaks sometimes and it fixes by itself, it's strange, and never found out the reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1st pass
Ok I spotted the problem with the Java SDK. The message payload on the Android side always has been different and I removed the payload code from the envelope. |
…tests in regard to message changes on Event
@lucas-zimerman left a few comments but LGTM. Thanks for doing this. |
all good :) |
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
For now I just run the sample and waited for an event from the native SDK.
https://sentry.io/organizations/sentry-sdks/discover/sentry-react-native:d1f62b5dbf5c4c8daf8f8bb737e2680f/?field=title&field=event.type&field=project&field=user.display&field=timestamp&name=All+Events&query=&sort=-timestamp&statsPeriod=24h&yAxis=count%28%29
📝 Checklist
🔮 Next steps
allowSyntheticDefaultImports