fix: Sampled needs to be false for v5 to discard it

getsentry · Mar 2, 2021 · 735a8d4 · 735a8d4
1 parent 53b228f
commit 735a8d4
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/js/tracing/reactnavigationv5.ts b/src/js/tracing/reactnavigationv5.ts
@@ -192,16 +192,17 @@ export class ReactNavigationV5Instrumentation extends RoutingInstrumentation {
           };
         }
 
-        if (finalContext.sampled) {
+        // Note: finalContext.sampled will be false at this point only if the user sets it to be so in beforeNavigate.
+        if (finalContext.sampled === false) {
+          logger.log(
+            `[ReactNavigationV5Instrumentation] Will not send transaction "${finalContext.name}" due to beforeNavigate.`
+          );
+        } else {
           // Clear the timeout so the transaction does not get cancelled.
           if (typeof this._stateChangeTimeout !== "undefined") {
             clearTimeout(this._stateChangeTimeout);
             this._stateChangeTimeout = undefined;
           }
-        } else {
-          logger.log(
-            `[ReactNavigationV5Instrumentation] Will not send transaction "${finalContext.name}" due to beforeNavigate.`
-          );
         }
 
         this._latestTransaction.updateWithContext(finalContext);