Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(ci): Remove TravisCI #962

Merged
merged 22 commits into from
Jan 7, 2021
Merged

build(ci): Remove TravisCI #962

merged 22 commits into from
Jan 7, 2021

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Jan 5, 2021

Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.

@billyvg
Copy link
Member Author

billyvg commented Jan 5, 2021

@untitaker Aside from zeus and ppc64le arch, do you see anything missing here?

We may be able to use https://github.com/marketplace/actions/run-on-architecture for a non amd64 arch.

@untitaker
Copy link
Member

@billyvg lgtm, feel free to remove ppc.

wrt zeus I will ask what other SDKs are doing right now

@jan-auer jan-auer self-assigned this Jan 5, 2021
@jan-auer
Copy link
Member

jan-auer commented Jan 5, 2021

@billyvg thanks for getting this started! I'll engage with you on this a little later. We should migrate to GH artifacts and the new publish actions like in sentry-javascript.

Would you mind if I propose a few simplifications to the CI setup, mostly consolidating most jobs in a single workflow? We've preferred that over too many workflows in the other SDKs and services that we have migrated so far.

@billyvg
Copy link
Member Author

billyvg commented Jan 5, 2021

@jan-auer Sounds good!

@jan-auer jan-auer removed their assignment Jan 6, 2021
@jan-auer
Copy link
Member

jan-auer commented Jan 6, 2021

Took the liberty to push a few changes directly to this branch:

  • Use GitHub artifacts instead of Zeus, compatible with craft
  • Change the craft status provider to GitHub
  • No longer upload coverage anywhere other than codecov
  • Add the current form of the release/publish action. It will be simplified pretty soon.
  • Change the bump-version script so it warns when run from macOS (our usual approach atm).

@billyvg This is G2G from my end, thanks for doing the heavy lifting!

@untitaker
Copy link
Member

untitaker commented Jan 6, 2021

going to trust y'all that the release workflow works

@billyvg
Copy link
Member Author

billyvg commented Jan 6, 2021

@untitaker is it expected that 3.8 and 3.9 are failing?

@untitaker
Copy link
Member

no. I will take a look tomorrow

@jan-auer
Copy link
Member

jan-auer commented Jan 6, 2021

Just noticed that I accidentally removed the build step for dists.

@untitaker is the intention to always build the dist or just on the release branch?

Separately, should we use venv instead of virtualenv to avoid having to install an additional package?

@jan-auer jan-auer force-pushed the build/ci/remove-travis-ci branch from 5b8be46 to fd7a9ee Compare January 6, 2021 17:35
@untitaker
Copy link
Member

@jan-auer

  1. we can only build on release branch
  2. we still support python 2 in the sdk, and venv does not work on python 2

@jan-auer jan-auer force-pushed the build/ci/remove-travis-ci branch from fd7a9ee to 72235cd Compare January 6, 2021 17:38
@billyvg
Copy link
Member Author

billyvg commented Jan 6, 2021

Thanks @jan-auer for rm'ing zeus.

And thanks @untitaker, can you take over this PR from here?

@jan-auer
Copy link
Member

jan-auer commented Jan 6, 2021

FWIW, 3.8 and 3.9 are failing on master already, so we can also merge as is and tackle the fixes in a follow-up.

@jan-auer
Copy link
Member

jan-auer commented Jan 6, 2021

That said, on the last two builds we received timeouts for the 3.7 test job:

The job running on runner GitHub Actions 36 has exceeded the maximum execution time of 30 minutes.

@billyvg
Copy link
Member Author

billyvg commented Jan 6, 2021

@jan-auer pypy is super slow, and 3.7 seems to also be failing (not just timing out)

@untitaker untitaker marked this pull request as ready for review January 7, 2021 20:13
@untitaker untitaker closed this Jan 7, 2021
@untitaker untitaker reopened this Jan 7, 2021
@untitaker
Copy link
Member

I have concerns about the severe slowdown in gha. Does this still pay off financially?

I fixed master and restarted the build. If it is green feel free to merge anytime

(yes we need to fix the testsuite itself too - - though I don't have any ideas atm. If you have opinions lmk and we can brainstorm on slack)

@billyvg
Copy link
Member Author

billyvg commented Jan 7, 2021

@untitaker yeah staying on travis is not an option for our active repos - I think if speed is an issue going forward, we can maybe parallelize? Not sure if that's doable with tox

@billyvg billyvg merged commit 64e781d into master Jan 7, 2021
@billyvg billyvg deleted the build/ci/remove-travis-ci branch January 7, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants