-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(ci): Remove TravisCI #962
Conversation
Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.
@untitaker Aside from zeus and We may be able to use https://github.com/marketplace/actions/run-on-architecture for a non amd64 arch. |
@billyvg lgtm, feel free to remove ppc. wrt zeus I will ask what other SDKs are doing right now |
@billyvg thanks for getting this started! I'll engage with you on this a little later. We should migrate to GH artifacts and the new publish actions like in Would you mind if I propose a few simplifications to the CI setup, mostly consolidating most jobs in a single workflow? We've preferred that over too many workflows in the other SDKs and services that we have migrated so far. |
@jan-auer Sounds good! |
Took the liberty to push a few changes directly to this branch:
@billyvg This is G2G from my end, thanks for doing the heavy lifting! |
going to trust y'all that the release workflow works |
@untitaker is it expected that 3.8 and 3.9 are failing? |
no. I will take a look tomorrow |
Just noticed that I accidentally removed the build step for dists. @untitaker is the intention to always build the dist or just on the release branch? Separately, should we use |
5b8be46
to
fd7a9ee
Compare
|
fd7a9ee
to
72235cd
Compare
Thanks @jan-auer for rm'ing zeus. And thanks @untitaker, can you take over this PR from here? |
FWIW, 3.8 and 3.9 are failing on master already, so we can also merge as is and tackle the fixes in a follow-up. |
That said, on the last two builds we received timeouts for the 3.7 test job:
|
@jan-auer pypy is super slow, and 3.7 seems to also be failing (not just timing out) |
I have concerns about the severe slowdown in gha. Does this still pay off financially? I fixed master and restarted the build. If it is green feel free to merge anytime (yes we need to fix the testsuite itself too - - though I don't have any ideas atm. If you have opinions lmk and we can brainstorm on slack) |
@untitaker yeah staying on travis is not an option for our active repos - I think if speed is an issue going forward, we can maybe parallelize? Not sure if that's doable with tox |
Travis sprung some surprise billing changes on us, so we are now prioritizing removing TravisCI completely.