-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scope): Emit buffer_overflow
discard reason when popping breadcrumbs
#3993
base: master
Are you sure you want to change the base?
Conversation
❌ 3 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
51e600f
to
2621c08
Compare
@AbhiPrasad The change looks good to me but we should have a test for this. I imagine we can come up with a test case by combining some of the client report tests in https://github.com/getsentry/sentry-python/blob/master/tests/test_transport.py and this Do you have some bandwidth to look into adding a test case? Otherwise I can try coming up with something. |
ref getsentry/team-sdks#116
This PR implements a new client discard reason for
buffer_overflow
. This will be used to track when the internal breadcrumbs buffer overflows for the new logs product that we are working on.log_item
is the new data category for logs, which we are basing out of breadcrumbs. Eventually we will be sending standalone envelope items that only contain breadcrumbs.