Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate enable_tracing option #3935

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

antonpirker
Copy link
Member

The option enable_tracing is deprecated in favor of using traces_sample_rate.

Fixes #3918

@antonpirker antonpirker self-assigned this Jan 14, 2025
Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.21%. Comparing base (8a70b76) to head (0fd6f23).
Report is 7 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3935      +/-   ##
==========================================
+ Coverage   80.16%   80.21%   +0.04%     
==========================================
  Files         139      139              
  Lines       15394    15397       +3     
  Branches     2596     2597       +1     
==========================================
+ Hits        12341    12351      +10     
+ Misses       2207     2202       -5     
+ Partials      846      844       -2     
Files with missing lines Coverage Δ
sentry_sdk/client.py 78.60% <100.00%> (+0.14%) ⬆️

... and 3 files with indirect coverage changes

@antonpirker antonpirker marked this pull request as ready for review January 14, 2025 14:43
@sentrivana
Copy link
Contributor

LGTM. Do we need a docs change, too?

@antonpirker
Copy link
Member Author

Good point @sentrivana, I added a docs Issue: getsentry/sentry-docs#12417

@antonpirker antonpirker merged commit 968b362 into master Jan 23, 2025
145 checks passed
@antonpirker antonpirker deleted the antonpirker/deprecate-enable-tracing branch January 23, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate enable_tracing option
3 participants