-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New processor system #34
Conversation
1598f13
to
0604d4b
Compare
0604d4b
to
aadf0af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda sad that a bunch of stuff moved back into utils
. Wanted to move things related to the processing pipeline out of there, regardless of whether there is an event pipeline. Apart from minor comments lgtm
identifier = "dedupe" | ||
|
||
def __init__(self): | ||
self._exceptions_seen = weakref.WeakKeyDictionary() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be unused.
@@ -66,6 +71,8 @@ def __init__(self, dsn=None, *args, **kwargs): | |||
) | |||
) | |||
|
|||
self._exceptions_seen = weakref.WeakKeyDictionary() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to be unused.
@@ -67,7 +67,7 @@ basepython = | |||
pypy: pypy | |||
|
|||
commands = | |||
py.test {env:TESTPATH} {posargs} | |||
py.test --tb=short {env:TESTPATH} {posargs} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying this option everywhere, i'd suggest to add a pytest.ini
:
[pytest]
addopts = --tb=short
Or alternatively in setup.cfg
:
[tool:pytest]
addopts = --tb=short
This is a WIP pull request to change the processor system to something we can document publicly. It also moves the deduping into an integration.