Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): Add litestar and starlite to get_sdk_name #3385

Merged
merged 4 commits into from
Aug 6, 2024
Merged

feat(integrations): Add litestar and starlite to get_sdk_name #3385

merged 4 commits into from
Aug 6, 2024

Conversation

KellyWalker
Copy link
Contributor

General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@KellyWalker
Copy link
Contributor Author

It seems like use of litestar and starlite should result in setting particular SDK names like other frameworks.

Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@KellyWalker KellyWalker marked this pull request as ready for review August 2, 2024 12:09
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (901a5e8) to head (6144eab).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3385      +/-   ##
==========================================
- Coverage   79.71%   79.66%   -0.05%     
==========================================
  Files         132      132              
  Lines       14264    14264              
  Branches     3003     3003              
==========================================
- Hits        11370    11363       -7     
- Misses       2071     2082      +11     
+ Partials      823      819       -4     
Files Coverage Δ
sentry_sdk/utils.py 83.14% <ø> (ø)

... and 4 files with indirect coverage changes

@antonpirker antonpirker enabled auto-merge (squash) August 6, 2024 06:51
@antonpirker antonpirker added the Trigger: tests using secrets PR code is safe; run CI label Aug 6, 2024
@antonpirker antonpirker merged commit 544b694 into getsentry:master Aug 6, 2024
125 of 127 checks passed
@KellyWalker KellyWalker deleted the feature/kelly/-add-starlite-litestar-to-get_sdk_name branch August 6, 2024 11:36
sentrivana pushed a commit that referenced this pull request Aug 12, 2024
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this pull request Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Trigger: tests using secrets PR code is safe; run CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants