Build new Lambda extension #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0b7c5fd to
8481d29
Compare
d86fe23 to
7dfde65
Compare
7dfde65 to
d5ce360
Compare
sl0thentr0py
reviewed
Apr 8, 2022
sl0thentr0py
approved these changes
Apr 8, 2022
antonpirker
added a commit
that referenced
this pull request
Jun 21, 2022
* Build new Lambda extension (#1383) * Use new GitHub action for creating Lambda layer zip. * Use new GitHub action for creating zip. * Replace original DSN host/port with localhost:3000 (#1414) * Added script for locally building/release Lambda layer * Added script to attach layer to function Co-authored-by: Neel Shah <neel.shah@sentry.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the build process of the AWS Lambda Layer to:
Prepare only a directory with all the Python code in the
makescript (as opposed to creating the directory and zipping it as beforeAdded the new sentry lambda extension from the release registry to the zip file
Zip the directory in a GitHub action.
and 3) are done in the new Github action: https://github.com/getsentry/action-build-aws-lambda-extension
(This makes it portable to the Javascript (and other) SDKs in the future)