Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(serverless): Python Serverless nocode instrumentation #1004

Merged
merged 29 commits into from
Feb 17, 2021

Conversation

ahmedetefy
Copy link
Contributor

@ahmedetefy ahmedetefy commented Feb 10, 2021

This PR adds the feature of being able to instrument python SDK into AWS lambda function without requiring the user to explicitly install the sentry SDK or initialize it

What was done in the PR?

  • Renamed scripts/build-aws-layer.py to scripts/build_aws_layer.py so that it is importable
  • Refactored build_aws_layer.py so that the code is reusable
  • Added scripts/init_serverless_sdk.py to initialize serverless sdk and reinvoke the Aws lambda layer handler function once initializing is complete. It is added to serverless sdk zip when it is created but is not part of the official sdk
  • e2e test to ensure that the no code instrumentation works

Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedetefy could you please add a PR description with a rationale?

@ahmedetefy
Copy link
Contributor Author

@rhcarvalho Added now, sorry!

@ahmedetefy ahmedetefy changed the title feat: Python Serverless nocode instrumentation feat(serverless): Python Serverless nocode instrumentation Feb 17, 2021
@ahmedetefy ahmedetefy merged commit 25125b5 into master Feb 17, 2021
@ahmedetefy ahmedetefy deleted the feat/python_serverless_nocode_instrumentation branch February 17, 2021 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants