-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serverless): Python Serverless nocode instrumentation #1004
Merged
ahmedetefy
merged 29 commits into
master
from
feat/python_serverless_nocode_instrumentation
Feb 17, 2021
Merged
feat(serverless): Python Serverless nocode instrumentation #1004
ahmedetefy
merged 29 commits into
master
from
feat/python_serverless_nocode_instrumentation
Feb 17, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/python_serverless_nocode_instrumentation
…/python_serverless_nocode_instrumentation
iker-barriocanal
approved these changes
Feb 16, 2021
rhcarvalho
suggested changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmedetefy could you please add a PR description with a rationale?
@rhcarvalho Added now, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the feature of being able to instrument python SDK into AWS lambda function without requiring the user to explicitly install the sentry SDK or initialize it
What was done in the PR?
scripts/build-aws-layer.py
toscripts/build_aws_layer.py
so that it is importablebuild_aws_layer.py
so that the code is reusablescripts/init_serverless_sdk.py
to initialize serverless sdk and reinvoke the Aws lambda layer handler function once initializing is complete. It is added to serverless sdk zip when it is created but is not part of the official sdk