Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sentry_sdk.push_scope in SDK #3345

Closed
szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3354 or #3353
Closed

Stop using sentry_sdk.push_scope in SDK #3345

szokeasaurusrex opened this issue Jul 25, 2024 · 0 comments · Fixed by #3354 or #3353
Assignees
@szokeasaurusrex

Comments

@szokeasaurusrex
Copy link
Member

We appear to mostly be using push_scope in tests. These usages should be removed, unless the test primarily exists to verify that push_scope continues to work even after being deprecated.
@szokeasaurusrex szokeasaurusrex self-assigned this Jul 26, 2024
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(basics): Replace push_scope
0b60ace 
Most of the `push_scope` usages in `test_basics.py` need to stay, as
they test functionality specific to `push_scope`.

However, in `test_scope_event_processor_order`, the `push_scope` can
be replaced with `new_scope`. We make this replacement here.

Ref: #3345
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 26, 2024
Merged
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(sessions): Replace push_scope
d09b113 
All usages of `sentry_sdk.push_scope` in `test_sessions.py` can be
replaced with `new_scope`.

Closes: #3345
@szokeasaurusrex szokeasaurusrex mentioned this issue Jul 26, 2024
Merged
This was linked to pull requests Jul 26, 2024
test(sessions): Replace push_scope #3354
Merged
test(basics): Replace push_scope #3353
Merged
szokeasaurusrex added a commit that referenced this issue Jul 26, 2024
@szokeasaurusrex
test(basics): Replace push_scope (#3353)
20ed5b7 
Most of the `push_scope` usages in `test_basics.py` need to stay, as
they test functionality specific to `push_scope`.

However, in `test_scope_event_processor_order`, the `push_scope` can
be replaced with `new_scope`. We make this replacement here.

Ref: #3345
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
test(basics): Replace push_scope (getsentry#3353)
9a33cc4 
Most of the `push_scope` usages in `test_basics.py` need to stay, as
they test functionality specific to `push_scope`.

However, in `test_scope_event_processor_order`, the `push_scope` can
be replaced with `new_scope`. We make this replacement here.

Ref: getsentry#3345
arjennienhuis pushed a commit to arjennienhuis/sentry-python that referenced this issue Sep 30, 2024
@szokeasaurusrex @arjenzorgdoc
test(sessions): Replace push_scope (getsentry#3354)
c9615af 
All usages of `sentry_sdk.push_scope` in `test_sessions.py` can be
replaced with `new_scope`.

Closes: getsentry#3345
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szokeasaurusrex szokeasaurusrex

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@szokeasaurusrex