fix: Rename AWS credential envvars to avoid collisions

scripts/aws-cleanup.sh

@@ -1,6 +1,11 @@
 #!/bin/sh
 # Delete all AWS Lambda functions
-for func in $(aws lambda list-functions | jq .Functions[].FunctionName); do
+
+export AWS_ACCESS_KEY_ID="$SENTRY_PYTHON_TEST_AWS_ACCESS_KEY_ID"
+export AWS_SECRET_ACCESS_KEY="$SENTRY_PYTHON_TEST_AWS_SECRET_ACCESS_KEY"
+export AWS_IAM_ROLE="$SENTRY_PYTHON_TEST_AWS_IAM_ROLE"
+
+for func in $(aws lambda list-functions | jq -r .Functions[].FunctionName); do
     echo "Deleting $func"
     aws lambda delete-function --function-name $func
 done

tests/integrations/aws_lambda/test_aws.py

@@ -47,13 +47,13 @@ def init_sdk(**extra_init_args):
 
 @pytest.fixture
 def lambda_client():
-    if "AWS_ACCESS_KEY_ID" not in os.environ:
+    if "SENTRY_PYTHON_TEST_AWS_ACCESS_KEY_ID" not in os.environ:
         pytest.skip("AWS environ vars not set")
 
     return boto3.client(
         "lambda",
-        aws_access_key_id=os.environ["AWS_ACCESS_KEY_ID"],
-        aws_secret_access_key=os.environ["AWS_SECRET_ACCESS_KEY"],
+        aws_access_key_id=os.environ["SENTRY_PYTHON_TEST_AWS_ACCESS_KEY_ID"],
+        aws_secret_access_key=os.environ["SENTRY_PYTHON_TEST_AWS_SECRET_ACCESS_KEY"],
         region_name="us-east-1",
     )
 
@@ -84,7 +84,7 @@ def inner(code, payload):
         lambda_client.create_function(
             FunctionName=fn_name,
             Runtime=runtime,
-            Role=os.environ["AWS_IAM_ROLE"],
+            Role=os.environ["SENTRY_PYTHON_TEST_AWS_IAM_ROLE"],
             Handler="test_lambda.test_handler",
             Code={"ZipFile": tmpdir.join("ball.zip").read(mode="rb")},
             Description="Created as part of testsuite for getsentry/sentry-python",

tox.ini

@@ -122,9 +122,9 @@ setenv =
 
     COVERAGE_FILE=.coverage-{envname}
 passenv =
-    AWS_ACCESS_KEY_ID
-    AWS_SECRET_ACCESS_KEY
-    AWS_IAM_ROLE
+    SENTRY_PYTHON_TEST_AWS_ACCESS_KEY_ID
+    SENTRY_PYTHON_TEST_AWS_SECRET_ACCESS_KEY
+    SENTRY_PYTHON_TEST_AWS_IAM_ROLE
 usedevelop = True
 extras =
     flask: flask