Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to changeable defaultMaxDepth in Serializer #802

Closed
wants to merge 1 commit into from

Conversation

howyi
Copy link

@howyi howyi commented Apr 8, 2019

I'd like to refer to the complicated nested JSON request in Sentry. 🙏

Fix #632 for sentry-php:v2 😃

closes #632

@howyi howyi changed the title Changeable defaultMaxDepth in Serializer Make it possible to changeable defaultMaxDepth in Serializer Apr 8, 2019
@Jean85
Copy link
Contributor

Jean85 commented Apr 9, 2019

I'm not sure I understand... How's this different from setting the max depth directly?

@howyi
Copy link
Author

howyi commented Apr 10, 2019

I'm sorry. 🙇
I thought that there is a problem that v2 can not set max_depth as well as #632. It is my mistake.
max_depth was now configurable on __contstruct(), thank you for great version up! 😄
This PR is closed.

If you intend to maintain v1 code, please review #632 if possible.... 📦

@howyi howyi closed this Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants