Implemented option for serializer max_depth #427
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't you want to fix code style issues? |
nokitakaze
reviewed
Apr 19, 2017
| { | ||
| if ($mb_detect_order != null) { | ||
| $this->mb_detect_order = $mb_detect_order; | ||
| } | ||
| if ( null !== $max_depth ) { |
There was a problem hiding this comment.
maybe !is_null($max_depth) ?
| { | ||
| $max_depth = null === $max_depth ? $this->max_depth : $max_depth; |
There was a problem hiding this comment.
Maybe
$max_depth = !is_null($max_depth) ? $max_depth : $this->max_depth;?
|
Okay. I need to add this pr to #454 |
|
This was done a long time ago and never updated with the latest changes so we cannot move forward with this PR right now. If it's updated we can reconsider it. Sorry it got left in the cold. Edit: See #632 for a more "current" PR doing about the same. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the possibility to define the default depth of the array serialization via configuration