Fix Xbox OS name #1148
Merged
Fix Xbox OS name #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2025 01:08
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
+ Coverage 82.74% 82.76% +0.02%
==========================================
Files 53 53
Lines 7939 7939
Branches 1239 1239
==========================================
+ Hits 6569 6571 +2
+ Misses 1260 1258 -2
Partials 110 110 |
supervacuus
approved these changes
Feb 11, 2025
| @@ -117,7 +117,7 @@ sentry__get_os_context(void) | |||
| # if defined(_GAMING_XBOX_SCARLETT) | |||
| # pragma warning(push) | |||
| # pragma warning(disable : 4996) | |||
| sentry_value_set_by_key(os, "name", sentry_value_new_string("Windows")); | |||
| sentry_value_set_by_key(os, "name", sentry_value_new_string("Xbox")); | |||
There was a problem hiding this comment.
Will the version number always match?
This also doesn't tell us which model (One, Series X or S etc)?
There was a problem hiding this comment.
Version number should always be accurate its pulled further in that code.
as of X vs S we would need to dig into part of the API we can not use publicly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue where the os name on Xbox was being reported as Windows.