Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deno): Build Sentry dependencies for tests #9312

Merged
merged 3 commits into from
Oct 25, 2023
Merged

fix(deno): Build Sentry dependencies for tests #9312

merged 3 commits into from
Oct 25, 2023

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 19, 2023

This PR adds a rollup config to build the core/utils/types Sentry dependencies that are used in the Deno tests.

@AbhiPrasad
Copy link
Member

@lforst do we need to merge this in?

@lforst
Copy link
Member

lforst commented Oct 24, 2023

@AbhiPrasad it's not urgent. This is just so we don't have to slap as many anys onto things and to avoid deeply relative import paths in the deno tests. I will take a look at this.

@lforst lforst self-requested a review October 24, 2023 14:01
@lforst lforst enabled auto-merge (squash) October 25, 2023 12:07
@lforst lforst merged commit f0b0281 into getsentry:develop Oct 25, 2023
@timfish timfish deleted the fix/deno-test-build branch December 13, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timfish @AbhiPrasad @lforst