-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Introduce startSpanManual #8913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What about having an API like this: Sentry.startActiveSpanManual(ctx, function(span, finish) {
// do something with span
// when you're done, call finish()
finish();
} Would make overwriting this for OTEL easier, as we can under the hood change what |
I like that a lot, thanks for the suggestion! |
mydea
reviewed
Aug 31, 2023
mydea
approved these changes
Aug 31, 2023
Lms24
reviewed
Sep 1, 2023
Lms24
approved these changes
Sep 1, 2023
temporarily putting this off until we make decision about naming tomorrow. |
91a8612
to
d844968
Compare
d844968
to
abbde7b
Compare
updated based on changes in #8971 |
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8911 and convos in slack, it was brought up that we might need to expose a method that works similar to
startSpan
, but that does not automatically finish the span at the end of the callback.This is necessary when you have event emitters (
res.once
) or similar.