Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sveltekit): Avoid invalidating data on route changes in wrapServerLoadWithSentry #8801

Merged
merged 3 commits into from
Aug 16, 2023
Merged

fix(sveltekit): Avoid invalidating data on route changes in wrapServerLoadWithSentry #8801

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
24e6346
fix(sveltekit): Avoid invalidating data o route changes in `wrapServe…
Lms24 Aug 11, 2023
13d3cef
handle event.route being undefined
Lms24 Aug 11, 2023
721c1de
Update packages/sveltekit/src/server/load.ts
Lms24 Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sveltekit/src/server/load.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ export function wrapServerLoadWithSentry<T extends (...args: any) => any>(origSe
// server `load` function's data on every route change.
// To work around this, we use `Object.getOwnPropertyDescriptor` which doesn't invoke the proxy.
// https://github.com/sveltejs/kit/blob/e133aba479fa9ba0e7f9e71512f5f937f0247e2c/packages/kit/src/runtime/server/page/load_data.js#L111C3-L124
const routeId = Object.getOwnPropertyDescriptor(event.route, 'id')?.value as string | undefined;
const routeId = event.route && (Object.getOwnPropertyDescriptor(event.route, 'id')?.value as string | undefined);
// const routeId = event.route.id;
Lms24 marked this conversation as resolved.
Show resolved Hide resolved

const { dynamicSamplingContext, traceparentData, propagationContext } = getTracePropagationData(event);
Expand Down