Fix RN frames on Android ... #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Don't treat presence of "native" string everywhere as meaning "native code" 2. Properly parse when not protocol / only leading forward slash fixes #731
benvinegar
commented
Mar 1, 2017
| @@ -396,7 +396,7 @@ TraceKit.computeStackTrace = (function computeStackTraceWrapper() { | |||
|
|
|||
| for (var i = 0, j = lines.length; i < j; ++i) { | |||
| if ((parts = chrome.exec(lines[i]))) { | |||
| var isNative = parts[2] && parts[2].indexOf('native') !== -1; | |||
| var isNative = parts[2] && parts[2].indexOf('native') === 0; // start of line | |||
There was a problem hiding this comment.
This is covered by the CHROME_48_BLOB test:
I've also verified the format is the same in my Chrome 56 (on the console):
setTimeout(function callback() {
[1].forEach(function iterate() { oops(); });
});Emits:
Uncaught ReferenceError: oops is not defined
at iterate (<anonymous>:2:36)
at Array.forEach (native) # <-- bingo
at callback (<anonymous>:2:7)
MaxBittker
approved these changes
Mar 3, 2017
|
@benvinegar @MaxBittker when will this be released? |
|
I could try and cut 3.13.2 tomorrow morning. |
|
@benvinegar that'll be awesome thanks |
|
@benvinegar any word on that release? |
|
@benvinegar ?? |
|
@f0rr0 – sorry, have been busy. It's not as easy as hitting a button, alas. |
|
@benvinegar sorry for bugging you, really appreciate this thanks |
|
We released 3.14.0 today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #731
See also: csnover/TraceKit#69
cc @getsentry/javascript