Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize RN frames in stackfrace interface (synthetic trace) (fixes #776) #778

Merged
merged 2 commits into from
Nov 22, 2016

Conversation

benvinegar
Copy link
Contributor

@@ -214,9 +214,10 @@ reactNativePlugin._normalizeData = function (data, pathStripRe) {
data.culprit = normalizeUrl(data.culprit, pathStripRe);
}

if (data.exception) {
var stacktrace = data.stacktrace || data.exception && data.exception.values[0].stacktrace;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe move this comment about data.exception guaranteeing other keys to be before this var decl; in its current position it doesn't obviously apply to data.exception.values[0], which made me wonder if that was a safe access until I looked at the original where it did obviously apply.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@benvinegar benvinegar merged commit 6fa89f2 into master Nov 22, 2016
@benvinegar benvinegar deleted the fix-rn-normalize branch November 22, 2016 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants