Bump grunt-mocha to 1.0.2 (+ phantomjs2 subdep) #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benvinegar
commented
Nov 18, 2016
| @@ -414,30 +414,22 @@ describe('integration', function () { | |||
| ); | |||
| }); | |||
|
|
|||
| it('should NOT capture breadcrumbs from XMLHttpRequests to the Sentry store endpoint', function (done) { | |||
| it('should NOT denote XMLHttpRequests to the Sentry store endpoint as requiring breadcrumb capture', function (done) { | |||
There was a problem hiding this comment.
Had to change this test because Phantom 2 throws a network error that DOES get collected as a (error) breadcrumb. Better that this test not attempt to make an XHR at all.
LewisJEllis
approved these changes
Nov 22, 2016
| // onreadystatechange fires), so enough to just verify that | ||
| // __raven_xhr wasn't set on xhr object | ||
|
|
||
| window.ravenData = '__raven_xhr' in xhr; |
There was a problem hiding this comment.
hasOwnProperty a bit safer here?
There was a problem hiding this comment.
It is 99.9999% unlikely to happen since we are controlling the environment, but sure.
| breadcrumbs = Raven._breadcrumbs; | ||
|
|
||
| assert.equal(breadcrumbs.length, 0); | ||
| assert.equal(iframe.contentWindow.ravenData, false); |
There was a problem hiding this comment.
Use assert.isFalse here? Or at least strictEqual...
There was a problem hiding this comment.
I agree this is better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was struggling to get tests running since I've upgraded to Phantom 2 for Sentry acceptance tests. Rather than figure things out, I've decided to blindly upgrade raven-js's deps to also use Phantom2.
cc @mattrobenolt @MaxBittker @LewisJEllis