Fix for IE8 Parsing error #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE8 Does not accept the trailing comma on Object definition. This fix let the IE8 parser to correctly parse the object instead of throwing an error for the trailing comma and exiting from the script.
benvinegar
approved these changes
Nov 15, 2016
|
@bud-mo – ugh, this is particularly painful, because neither ESLint nor our preprocessors made this safe. We will immediately release 3.8.1 with this fix and follow-up to make sure processes are in place so that it doesn't occur again. |
|
Introduced in 3671931 |
benvinegar
pushed a commit
that referenced
this pull request
Nov 15, 2016
|
#771 hopefully means that this won't happen again |
denstepa
pushed a commit
to denstepa/raven-js
that referenced
this pull request
Jan 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE8 Does not accept the trailing comma on Object definition.
This fix let the IE8 parser to correctly parse the object instead of throwing an error for the trailing comma and exiting from the script.