Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: Update changelog for 7.39.0 #7284

Merged
merged 25 commits into from
Feb 27, 2023
Merged

meta: Update changelog for 7.39.0 #7284

merged 25 commits into from
Feb 27, 2023

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 27, 2023 •
edited
Loading

github-actions bot and others added 23 commits February 17, 2023 13:35
@github-actions
Merge pull request #7220 from getsentry/master
e44600f 
[Gitflow] Merge master into develop
@Lms24
test(replay): Normalize time offset in DOM snapshots (#7219)
aa1d4e5 
Normalize timeOffset entry in snapshots to avoid flakiness
@Lms24
test(wasm): Move WASM test to Playwright and remove Puppeteer (#7217)
00d2360 
Move the integration test for our WASM integration to our Playwright browser integration test suite. With this change we finally get rid of Puppeteer in our monorepo.
@Lms24
test(replay): Add test for fetch and XHR performance spans (#7224)
7f4c4ec
@JamesHenry @mydea
chore: make unit tests cacheable, fix package graph (#7108)
b2e866a 
---------

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@mydea
ci: Fix adding size info to release (#7221)
c46c56c
@lforst
feat(nextjs): Default to VERCEL_ENV as environment (#7227)
fad6c48
@timfish
fix(core): Exclude client reports from offline queuing (#7226)
12e34d4
@mydea
test(replay): Test that blocking elements works as expected (#7201)
b04a6d4
@mydea
ci: Run nightly build without cache (#7235)
f5b7b10
@mydea
test(replay): Add test for continuous flushing (#7240)
b1b249b
@mydea
ci: Add timeout to integration tests job (#7243)
e25c067
@lucas-zimerman
feat(replay): Add more default block filters (#7233)
e60cd02
@Lms24
test(replay): Ensure that unicode characters are handled correctly (#…
c5c223c 
…7252)
@mydea
feat(tracing): Add enableTracing option (#7238)
46a527b
@Lms24
test(replay): Add Playwright tests for error-mode and error linking (#…
9c2c018 
…7251)

Add four integration tests for replays where errors occur:

* error mode:
  * error to session transition once the error occurs
  * if the error is dropped, it shouldn't be linked in the replay event (see test comment about the problem with this scenario)
* session mode
  * if an error occurs, make sure it's linked in the replay event
  * unless the error is dropped
@lforst
fix(nextjs): Export serverside data-fetcher wrappers from client (#7256)
e24127c
@lforst
feat: Add source map images to debug_meta (#7168)
e4d3146
@billyvg @Lms24
fix(replay): Fix timestamps on LCP (#7225)
8e27ff9 
`value` was being used as ms but start/end timestamps are in seconds. Changed start and end to be equal because LCP does not have a duration, it is a single point in time.

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@lforst @AbhiPrasad
test: Add test utility to intercept requests to Sentry (#7271)
21fb51b 
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@AbhiPrasad
feat(loader): Make lazy-loading configurable (#7232)
87e919c
@lforst @AbhiPrasad
feat(nextjs): Add performance monitoring to server components (#7242)
4b95c04 
Co-authored-by: Abhijeet Prasad <aprasad@sentry.io>
@Lms24
feat(angular): Add Ivy-compatible Angular SDK package (#7264)
cca2514 
Add a new SDK package to our monorepo: `@sentry/angular-ivy`. 

While this is technically a new SDK, its content and functionality is identical to `@sentry/angular`. Only the build configuration differs:

* The Ivy SDK is built with Angular 12, allowing for a compatibility of NG12-15
* The Ivy SDK is built with `compilationMode: partial`, enabeling a build format that is compatible with Angular's Ivy rendering engine. 
  * This means that `ngcc` no longer needs to step in at initial build time to up-compile the SDK. Which is good because `ngcc` will be removed in Angular 16 (angular/angular-cli#24720)
* The Ivy SDK's build output follows the Angular Package Format (APF) v12 standard ([spec](https://docs.google.com/document/d/1CZC2rcpxffTDfRDs6p1cfbmKNLA6x5O-NtkJglDaBVs/preview)) which is very similar to APF 10 which we used before (see #4641 for more details)

Because functionality-wise there's no difference to `@sentry/angular`, I opted to symlink the source files instead of duplicating them. The only exception is `sdk.ts` which needed some adaption for the new package, like setting the SDK name and adjusting the min version check. For the same reason, this new package currently doesn't contain tests. We'll need to reconsider this approach (symlinking and testing) if we ever need to make package-specific adjustments.
@Lms24 Lms24 requested review from a team, mydea and lforst and removed request for a team February 27, 2023 12:46
@Lms24 Lms24 mentioned this pull request Feb 27, 2023
Merged
mydea
mydea reviewed Feb 27, 2023
View reviewed changes
mydea
mydea reviewed Feb 27, 2023
View reviewed changes
@Lms24
ref(replay): Update rrweb to 1.104.1 (#7283)
80cb7a5 
From 1.103.0 to 1.104.0 to 1.104.1
@Lms24 Lms24 force-pushed the prepare-release/7.39.0 branch from 067708b to 97094e4 Compare February 27, 2023 13:34
@Lms24 Lms24 changed the base branch from develop to master February 27, 2023 13:35
@Lms24 Lms24 requested a review from mydea February 27, 2023 13:35
@mydea
Copy link
Member

mydea commented Feb 27, 2023

Ah, ideally you can squash the changelog commits together before merging this (as they will remain in the state after being merged)!

@Lms24 Lms24 changed the base branch from master to develop February 27, 2023 13:41
@Lms24 @mydea
update changelog for 7.39.0
cc119e3 
add sentence about ivy

Apply suggestions from code review

Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
@Lms24 Lms24 force-pushed the prepare-release/7.39.0 branch from 97094e4 to cc119e3 Compare February 27, 2023 13:44
@Lms24
Copy link
Member Author

Lms24 commented Feb 27, 2023

Done

@Lms24 Lms24 changed the base branch from develop to master February 27, 2023 13:46
@Lms24 Lms24 merged commit 59dc6ff into master Feb 27, 2023
@Lms24 Lms24 deleted the prepare-release/7.39.0 branch February 27, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Lms24 @mydea @JamesHenry @lforst @timfish @lucas-zimerman @billyvg @AbhiPrasad