Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the DSN after configuration #706

Merged
merged 3 commits into from
Aug 30, 2016

Conversation

mike-zorn
Copy link
Contributor

@mike-zorn mike-zorn commented Aug 27, 2016

Addresses #650.

@benvinegar, I just made this quickly in the github editor to better explain what I meant, so excuse any errors: this isn't ready for merge. Does this approach seem reasonable?


This change is Reviewable

@benvinegar
Copy link
Contributor

Yeah this seems reasonable, although could you change it to setDSN to match the private method _parseDSN?

@mike-zorn
Copy link
Contributor Author

@benvinegar I've updated the PR to make the naming consistent and add a test. Let me know if it's acceptable.

@benvinegar
Copy link
Contributor

It would be nice if this could be done via config (i.e. call config a second time) so we wouldn't have to introduce another API method, but ... it's unclear what would happen to your previously set configuration (e.g. does it reset to defaults). I can see a case where just being able to toggle the DSN, free of other side effects, is useful. So going ahead w/ merging.

@benvinegar
Copy link
Contributor

Reviewed 2 of 2 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@benvinegar benvinegar merged commit c474a32 into getsentry:master Aug 30, 2016
denstepa pushed a commit to denstepa/raven-js that referenced this pull request Jan 5, 2017
@ginomiglio ginomiglio mentioned this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants