Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment configuration #661

Merged
merged 1 commit into from
Jul 26, 2016
Merged

Add environment configuration #661

merged 1 commit into from
Jul 26, 2016

Conversation

dcramer
Copy link
Member

@dcramer dcramer commented Jul 23, 2016

@getsentry/javascript

Fixes GH-660


This change is Reviewable

@benvinegar
Copy link
Contributor

Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/raven.js, line 445 [r1] (raw file):

        return this;
    },

I realize we have setRelease, setTransport and others, but I'm concerned about a future where we have setX for every possible config option potentially bloating the library.

Approving tho ...


Comments from Reviewable

@dcramer
Copy link
Member Author

dcramer commented Jul 26, 2016

Review status: all files reviewed at latest revision, 1 unresolved discussion.


src/raven.js, line 445 [r1] (raw file):

Previously, benvinegar (Ben Vinegar) wrote…

I realize we have setRelease, setTransport and others, but I'm concerned about a future where we have setX for every possible config option potentially bloating the library.

Approving tho ...

fyi commenting blocks the review unless you change the status or use something like 'btw' to prefix it

Comments from Reviewable

@dcramer
Copy link
Member Author

dcramer commented Jul 26, 2016

feel free to hijack and/or just merge this when you feel its good


Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@benvinegar
Copy link
Contributor

Reviewed 1 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@benvinegar benvinegar merged commit 4a8591b into master Jul 26, 2016
@benvinegar benvinegar deleted the feature/environment branch July 26, 2016 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants