Fix console plugin circular dep causing bad CDN build #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nothing bad sticks out but I'm also not particularly familiar with how we include the plugins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So ... including plugins/console.js into raven.js was a bad idea. It created a circular dependency where console.js => singleton.js => raven.js => console.js (and so on) ... causing the CDN build to error because of the way plugins are auto-initialized.
My solution is to create a new file
src/console.jsand utility methodwrapMethodthat is shared by both raven.js and plugins/console.js. No more circular dependency, no more tears, and the CDN version now builds fine.There were already unit + integration tests for the console plugin and console breadcrumbs, and everything seems green.
Will cut 3.0.1 after this lands.
cc @mitsuhiko @mattrobenolt