Log arguments in extra so that they do not need to be stringified #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Log arguments in extra so that they do not need to be stringified. This provides more context for use when debugging errors.
| @@ -23,7 +23,7 @@ var logForGivenLevel = function(level) { | |||
| if (level === 'warn') level = 'warning'; | |||
| return function () { | |||
| var args = [].slice.call(arguments); | |||
| Raven.captureMessage('' + args, {level: level, logger: 'console'}); | |||
| Raven.captureMessage('' + args[0], {level: level, logger: 'console', extra: { args: args }}); | |||
There was a problem hiding this comment.
Would we want to do { args: args.slice(1) } instead? Since this is already sending the first argument as the message.
Also, I think I'd prefer to send the key as arguments rather than args since arguments is what it's really called. :)
There was a problem hiding this comment.
Re args.slice(1): I would prefer to keep all all the arguments in extras because you can have a complex object in the first argument of console.xxx() as well. You do not want to have to recommit your code just because you forgot that the first argument should be a string...
There was a problem hiding this comment.
Ah, that's probably reasonable. 👍
So the intent becomes more clear.
|
Thanks! 🍰 🎉 |
mattrobenolt
added a commit
that referenced
this pull request
Oct 31, 2015
Log arguments in extra so that they do not need to be stringified
|
Thank you for accepting the branch - and THANK YOU for RavenJS and Sentry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log arguments in extra so that they do not need to be stringified. This provides more context for use when debugging errors.