Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guard against document.location being null or undefined #357

Merged
merged 2 commits into from
Jul 25, 2015
Merged

Conversation

mattrobenolt
Copy link
Contributor

fixes #356

@mattrobenolt
Copy link
Contributor Author

@pkaminski do you think this is reasonable? Not sure if it'd make sense to put something in http.url as the fallback, like <unknown>.

@pkaminski
Copy link
Contributor

Seems reasonable to me, assuming that nothing bad happens in Sentry when the field isn't set. Since the condition happens very rarely I don't think it's worth overthinking this -- just make sure it doesn't crash and take the original exception with it. 😄

@dcramer
Copy link
Member

dcramer commented Jul 24, 2015

imo delete http -- id prefer not to allow an optional http url, even if we do today (we may not im not sure)

@dcramer dcramer merged commit 455e357 into master Jul 25, 2015
@mattrobenolt mattrobenolt deleted the location branch October 22, 2015 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

document.location is null
3 participants