Update Backbone.js plugin to handle event map syntax. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| if (typeof name === 'object') { | ||
| // Handle event maps. | ||
| for (var key in name) { |
There was a problem hiding this comment.
This also needs to check if key is inside name's prototype.
|
Other than those couple comments, this seems reasonable. |
|
I think I've addressed all the comments, but please let me know if I missed (or mis-interpreted) anything! |
|
Seems reasonable to me. Thanks. 🍰 ✨ |
mattrobenolt
added a commit
that referenced
this pull request
Jan 9, 2015
Update Backbone.js plugin to handle event map syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #306.
.on()using event map syntax.