Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(integrations): Add localforage typing #2856

Merged
merged 2 commits into from
Aug 28, 2020
Merged

fix(integrations): Add localforage typing #2856

merged 2 commits into from
Aug 28, 2020

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Aug 27, 2020 •
edited by rhcarvalho
Loading

Fixes #2853.

@AbhiPrasad AbhiPrasad requested a review from a team August 27, 2020 20:51
@AbhiPrasad AbhiPrasad mentioned this pull request Aug 27, 2020
Closed
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2020 •
edited
Loading

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 17.68 KB (0%)
@sentry/browser - Webpack 18.47 KB (0%)
@sentry/react - Webpack 18.47 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 22.77 KB (-0.01% 🔽)

rhcarvalho
rhcarvalho approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@rhcarvalho rhcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AbhiPrasad! Looks like you had a different version of prettier running, I've reverted the formatting changes to fix the lint job.

@rhcarvalho rhcarvalho merged commit b62a4d3 into master Aug 28, 2020
@rhcarvalho rhcarvalho deleted the abhi/fix-localforage branch August 28, 2020 07:41
@iamsimakov
Copy link

@rhcarvalho hello, could you publish fixed package to npm, please?

@HazAT
Copy link
Member

HazAT commented Aug 28, 2020

@iamsimakov 5.22.1 has been released

@davidmyersdev davidmyersdev mentioned this pull request Sep 1, 2020
Closed
7 tasks
@lobsterkatie lobsterkatie mentioned this pull request May 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhcarvalho rhcarvalho rhcarvalho approved these changes

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot find name 'LocalForage'.
4 participants
@AbhiPrasad @iamsimakov @HazAT @rhcarvalho