ref(feedback): Refactor screenshot editor into multiple files #15362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
ryan953
reviewed
Feb 10, 2025
|
|
||
| return function ScreenshotEditor({ onError }: Props): VNode { | ||
| const styles = hooks.useMemo(() => ({ __html: createScreenshotInputStyles(options.styleNonce).innerText }), []); | ||
|
|
||
| const canvasContainerRef = hooks.useRef<HTMLDivElement>(null); | ||
| const cropContainerRef = hooks.useRef<HTMLDivElement>(null); | ||
| const croppingRef = hooks.useRef<HTMLCanvasElement>(null); | ||
| const annotatingRef = hooks.useRef<HTMLCanvasElement>(null); |
There was a problem hiding this comment.
What if this useRef call was just inside Annotations.tsx?
There was a problem hiding this comment.
it's used in screenshot editor when resizing
There was a problem hiding this comment.
oh i missed that. i'll take another look. it's a non-blocking kind of thing too
❌ 416 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
ryan953
reviewed
Feb 10, 2025
| setCroppingRect={setCroppingRect} | ||
| resize={resize} | ||
| /> | ||
| <Annotations action={action} imageBuffer={imageBuffer} annotatingRef={annotatingRef} /> |
There was a problem hiding this comment.
Would it work if this was like:
Suggested change
| <Annotations action={action} imageBuffer={imageBuffer} annotatingRef={annotatingRef} /> | |
| {action === 'annotate' ? <Annotations imageBuffer={imageBuffer} annotatingRef={annotatingRef} /> : null} |
same for options._experiments.annotations || action === 'crop' ? <Crop> : null
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
reviewed
Feb 10, 2025
ryan953
approved these changes
Feb 10, 2025
billyvg
approved these changes
Feb 11, 2025
Comment on lines
+101
to
+103
| if (action !== 'crop') { | ||
| return; | ||
| } |
There was a problem hiding this comment.
When/why would this component get a non crop action?
There was a problem hiding this comment.
it's in a useEffect with action as a dependency. This is done so that when you switch from cropping to the annotation tool, the above part of the code will run and clear the rectangle drawn around the image.
| <button | ||
| class={`editor__tool ${action === 'crop' ? 'editor__tool--active' : ''}`} | ||
| onClick={e => { | ||
| e.preventDefault(); |
There was a problem hiding this comment.
what's the default behavior that this stops?
(you might need a type="button" if it's submitting a form)
There was a problem hiding this comment.
it is submitting the form 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are splitting up screenshot editor into 3 additional parts: cropping, annotations, toolbar