Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node): Remove last example.com requests in node integration tests #15333

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Feb 6, 2025

Refactors two flaky Node integration tests that made requests to example.com. Now we just spin up our own test server instead.

@Lms24 Lms24 requested a review from mydea February 6, 2025 17:38
@Lms24 Lms24 self-assigned this Feb 6, 2025
@Lms24 Lms24 merged commit dd55860 into develop Feb 7, 2025
31 checks passed
@Lms24 Lms24 deleted the lms/test-unflake-node-integration-tests-example.com branch February 7, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants