fix(aws-lambda): Avoid overwriting root span name #15000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mydea
approved these changes
Jan 14, 2025
c50718e to
b930e03
Compare
size-limit report 📦
|
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky tests
To view more test analytics, go to the Test Analytics Dashboard |
Lms24
added a commit
that referenced
this pull request
Jan 17, 2025
Calls `scope.updateTransactionName` which updates the error location "transaction" name on the scope. This is only applied to error events during event processing, so the intention is clearer than adding an event processor.
Lms24
added a commit
that referenced
this pull request
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across this by chance: Updating
event.transactionin an event processor without checking for the type also always overwrites the root span name. To fix this, this PR callsscope.updateTransactionNamewhich updates the error location "transaction" name on the scope. This is only applied to error events during event processing, so the intention is clearer than adding an event processor.This was mentioned in #13391 but admittedly I must have misread the issue because I'm 99% sure the event processor was unintended behaviour from our end.