Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Use OTEL instrumentation for route handlers #13887

Merged
merged 6 commits into from
Oct 8, 2024

Conversation

chargome
Copy link
Member

@chargome chargome commented Oct 7, 2024

fixes #13593

Copy link
Contributor

github-actions bot commented Oct 7, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.73 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 34.97 KB added added
@sentry/browser (incl. Tracing, Replay) 71.5 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.91 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 75.82 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 88.59 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.46 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.87 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.17 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 37.94 KB added added
@sentry/vue 26.9 KB added added
@sentry/vue (incl. Tracing) 36.86 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.05 KB added added
CDN Bundle (incl. Tracing) 36.76 KB added added
CDN Bundle (incl. Tracing, Replay) 71.24 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.55 KB added added
CDN Bundle - uncompressed 70.53 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.04 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.93 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 234.15 KB added added
@sentry/nextjs (client) 37.91 KB added added
@sentry/sveltekit (client) 35.56 KB added added
@sentry/node 125.03 KB added added
@sentry/node - without tracing 93.48 KB added added
@sentry/aws-serverless 103.17 KB added added

Copy link

codecov bot commented Oct 7, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
228 1 227 14
View the top 1 failed tests by shortest run time
route-handlers.test.ts Should record exceptions and transactions for faulty route handlers
Stack Traces | 0.095s run time
route-handlers.test.ts:35:5 Should record exceptions and transactions for faulty route handlers

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@chargome chargome force-pushed the cg/nextjs-route-handler-otel branch from afd2a41 to f2e4a82 Compare October 7, 2024 11:37
@chargome chargome self-assigned this Oct 8, 2024
@chargome chargome requested a review from lforst October 8, 2024 13:52
@chargome chargome merged commit 121bcee into lforst-nextjs-otel Oct 8, 2024
113 checks passed
@chargome chargome deleted the cg/nextjs-route-handler-otel branch October 8, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants