Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(core): Reduce hasTracingEnabled size #13232

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Aug 5, 2024

A very small PR that should shave off a couple of bytes of hasTracingEnabled.

Inlining the function removes the function declaration from the bundle.

@Lms24 Lms24 self-assigned this Aug 5, 2024
@Lms24 Lms24 requested review from a team, stephanie-anderson, s1gr1d and andreiborza and removed request for a team and stephanie-anderson August 5, 2024 13:56
Copy link
Contributor

github-actions bot commented Aug 5, 2024

size-limit report 📦

Path Size
@sentry/browser 22.46 KB (0%)
@sentry/browser (incl. Tracing) 34.24 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) 70.29 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.63 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 74.69 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 87.29 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 89.13 KB (-0.01% 🔽)
@sentry/browser (incl. metrics) 26.76 KB (0%)
@sentry/browser (incl. Feedback) 39.39 KB (0%)
@sentry/browser (incl. sendFeedback) 27.08 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.72 KB (0%)
@sentry/react 25.22 KB (0%)
@sentry/react (incl. Tracing) 37.23 KB (+0.01% 🔺)
@sentry/vue 26.61 KB (+0.01% 🔺)
@sentry/vue (incl. Tracing) 36.08 KB (+0.02% 🔺)
@sentry/svelte 22.59 KB (0%)
CDN Bundle 23.65 KB (0%)
CDN Bundle (incl. Tracing) 35.89 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay) 70.31 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.58 KB (-0.01% 🔽)
CDN Bundle - uncompressed 69.4 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 106.3 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.14 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.06 KB (-0.02% 🔽)
@sentry/nextjs (client) 37.07 KB (-0.03% 🔽)
@sentry/sveltekit (client) 34.8 KB (-0.04% 🔽)
@sentry/node 114.77 KB (-0.01% 🔽)
@sentry/node - without tracing 89.33 KB (0%)
@sentry/aws-serverless 98.5 KB (+0.01% 🔺)

@Lms24 Lms24 enabled auto-merge (squash) August 5, 2024 14:26
@Lms24 Lms24 merged commit 7fc479f into develop Aug 6, 2024
124 checks passed
@Lms24 Lms24 deleted the lms/ref-hasTracingEnabled-size branch August 6, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants