Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(browser-integration-tests): Add trace lifetime tests in TwP scenario #11636

Merged
merged 2 commits into from
Apr 17, 2024
Merged

test(browser-integration-tests): Add trace lifetime tests in TwP scenario #11636

merged 2 commits into from
Apr 17, 2024

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 16, 2024 •
edited
Loading

Adds a couple of tests to cover the "Tracing Without Performance" use case where no spans will be created but we nevertheless attach tracing headers to outgoing requests and attach a trace id to errors. Also, we expect these traceIds to be different/new for each subsequent navigation

ref #11599

@Lms24 Lms24 changed the base branch from develop to lms/feat-browser-update-propagationContext-spanEnd April 16, 2024 16:03
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 31.46 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing, Replay) 66.79 KB (+0.12% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.19 KB (+0.13% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.62 KB (+0.11% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.5 KB (+0.11% 🔺)
@sentry/browser (incl. Feedback) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.28 KB (0%)
@sentry/browser (incl. sendFeedback) 26.46 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 34.37 KB (+0.22% 🔺)
@sentry/vue 25.2 KB (0%)
@sentry/vue (incl. Tracing) 33.18 KB (+0.22% 🔺)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 32.76 KB (+0.25% 🔺)
CDN Bundle (incl. Tracing, Replay) 66.4 KB (+0.11% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.6 KB (+0.1% 🔺)
CDN Bundle - uncompressed 70.86 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.59 KB (+0.24% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.25 KB (+0.11% 🔺)
@sentry/nextjs (client) 33.7 KB (+0.23% 🔺)
@sentry/sveltekit (client) 31.96 KB (+0.23% 🔺)
@sentry/node 153.46 KB (0%)

@Lms24 Lms24 self-assigned this Apr 16, 2024
@Lms24 Lms24 mentioned this pull request Apr 16, 2024
Closed
@Lms24 Lms24 force-pushed the lms/test-browser-twp-trace-lifetime branch from b5fcd20 to 0a5b61e Compare April 17, 2024 10:14
Base automatically changed from lms/feat-browser-update-propagationContext-spanEnd to develop April 17, 2024 11:39
@Lms24 Lms24 force-pushed the lms/test-browser-twp-trace-lifetime branch from 0a5b61e to 5ea734d Compare April 17, 2024 11:41
@Lms24 Lms24 requested review from a team, mydea and AbhiPrasad and removed request for a team April 17, 2024 11:41
@Lms24 Lms24 marked this pull request as ready for review April 17, 2024 11:41
@Lms24 Lms24 merged commit e474a57 into develop Apr 17, 2024
78 checks passed
@Lms24 Lms24 deleted the lms/test-browser-twp-trace-lifetime branch April 17, 2024 12:05
Lms24 added a commit that referenced this pull request Apr 17, 2024
@Lms24
test(browser-integration-tests): Add trace lifetime tests in TwP scen…
2ce7105 
…ario (#11636)

Adds a couple of tests to cover the "Tracing Without Performance" use
case where no spans will be created but we nevertheless attach tracing
headers to outgoing requests and attach a trace id to errors. Also, we
expect these traceIds to be different/new for each subsequent navigation

ref #11599
@Lms24 Lms24 mentioned this pull request Apr 17, 2024
Merged
Lms24 added a commit that referenced this pull request Apr 17, 2024
@Lms24
test(browser-integration-tests): Add trace lifetime tests in TwP scen…
6c8aeff 
…ario (#11636) (#11659)

For some reason, this commit (#11564) caused a conflict in our
master->develop sync. Let's fix this by cherry picking it onto master.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@AbhiPrasad AbhiPrasad Awaiting requested review from AbhiPrasad AbhiPrasad was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lms24 @mydea