test(browser-integration-test): Add tests to check trace lifetime in user feedback events #11626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
… user feedback events
32c55db to
cdbcdc0
Compare
mydea
added a commit
that referenced
this pull request
May 3, 2024
This PR adds a new `captureFeedback` method which is exported from all SDKs. This method can be used to capture a (new) user feedback from any package. We follow the same semantics as for other capture methods like `captureException()` or `captureMessage()`: The method returns a string, which is the event id. We do not wait for sending to be successful or not, we just try to send it and return. You can both set an `associatedEventId` (which replaces the event_id of the "old" `captureUserFeedback`), and also pass attachments to send along (which for now are sent as a separate envelope). For usage in the modal UI, there is still `sendFeedback` which continues to return a promise that resolves with the event ID, or rejects with a meaningful error message if sending fails. This also deprecates `captureUserFeedback()`, which is only exported in browser. We cannot remove this yet because `captureFeedback` will only work on newer self-hosted instances, so not all users can easily update. We can/should remove this in v9. Includes #11626 Fixes 49946
|
Closing, these tests were added in #11428 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: These tests depend on #11428. Currently, feedback events have no trace context at all, so these tests fail.
Once #11428 is merged, we can/should also test programatically calling
captureFeedback.ref #11599