fix: Fix toString usage for function wrapped using wrap method #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBittker
approved these changes
Nov 16, 2017
src/raven.js
Outdated
| @@ -367,7 +367,7 @@ Raven.prototype = { | |||
| // Signal that this function has been wrapped already | |||
| // for both debugging and to prevent it to being wrapped twice | |||
There was a problem hiding this comment.
we should comment that this could mean raven wrapped or filled
5887978 to
7a6e305
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1132 (comment)
It broke, because
zone.jshas some code that's triggered for IE/Edge only, and it modified calls context – https://github.com/angular/zone.js/blob/dcc285aab37bdd90b6d7133fc73045100861c61c/lib/browser/event-target.ts#L67-L97This caused all
wrapcalls to be passed through it, and calledtoStringon them – https://github.com/angular/zone.js/blob/dcc285aab37bdd90b6d7133fc73045100861c61c/lib/browser/event-target.ts#L82 Because of that,function wrapped, which we return fromwrapcalls was given as a context toFunction.prototype.toString.apply, as it also contains__raven__flag set totrue.`The problem was, that all functions wrapped with either
wrapandfillhad mentioned__raven__flags, but original function on one of them was called__inner__and one__orig_method__. This was untraceable with tests, as it's just an odd edge case, wherezone.jsoverrides all API methods and thencore.jspolyfills some of them.Oh well... ¯_(ツ)_/¯